Include error message when index is zero

Author: dvd101x

src/expression/transform/range.transform.js

@@ -2,10 +2,10 @@ import { factory } from '../../utils/factory.js'
 import { createRange } from '../../function/matrix/range.js'
 
 const name = 'range'
-const dependencies = ['typed', 'config', '?matrix', '?bignumber', 'equal', 'smaller', 'smallerEq', 'larger', 'largerEq', 'add', 'isPositive']
+const dependencies = ['typed', 'config', '?matrix', '?bignumber', 'equal', 'smaller', 'smallerEq', 'larger', 'largerEq', 'add', 'isZero', 'isPositive']
 
-export const createRangeTransform = /* #__PURE__ */ factory(name, dependencies, ({ typed, config, matrix, bignumber, equal, smaller, smallerEq, larger, largerEq, add, isPositive }) => {
-  const range = createRange({ typed, config, matrix, bignumber, equal, smaller, smallerEq, larger, largerEq, add, isPositive })
+export const createRangeTransform = /* #__PURE__ */ factory(name, dependencies, ({ typed, config, matrix, bignumber, equal, smaller, smallerEq, larger, largerEq, add, isZero, isPositive }) => {
+  const range = createRange({ typed, config, matrix, bignumber, equal, smaller, smallerEq, larger, largerEq, add, isZero, isPositive })
 
   /**
    * Attach a transform function to math.range

src/function/matrix/range.js

@@ -2,9 +2,9 @@ import { factory } from '../../utils/factory.js'
 import { noBignumber, noMatrix } from '../../utils/noop.js'
 
 const name = 'range'
-const dependencies = ['typed', 'config', '?matrix', '?bignumber', 'equal', 'smaller', 'smallerEq', 'larger', 'largerEq', 'add', 'isPositive']
+const dependencies = ['typed', 'config', '?matrix', '?bignumber', 'equal', 'smaller', 'smallerEq', 'larger', 'largerEq', 'add', 'isZero', 'isPositive']
 
-export const createRange = /* #__PURE__ */ factory(name, dependencies, ({ typed, config, matrix, bignumber, equal, smaller, smallerEq, larger, largerEq, add, isPositive }) => {
+export const createRange = /* #__PURE__ */ factory(name, dependencies, ({ typed, config, matrix, bignumber, smaller, smallerEq, larger, largerEq, add, isZero, isPositive }) => {
   /**
    * Create a matrix or array containing a range of values.
    * By default, the range end is excluded. This can be customized by providing
@@ -190,7 +190,7 @@ export const createRange = /* #__PURE__ */ factory(name, dependencies, ({ typed,
    */
   function _range (start, end, step, includeEnd) {
     const array = []
-    if (equal(start, end)) return array
+    if (isZero(step)) throw new Error('Step must be non-zero')
     const ongoing = isPositive(step)
       ? includeEnd ? smallerEq : smaller
       : includeEnd ? largerEq : larger

test/unit-tests/function/matrix/range.test.js

@@ -36,22 +36,27 @@ describe('range', function () {
     assert.deepStrictEqual(range(2, -4, -2), matrix([2, 0, -2]))
   })
 
-  it('should create an empty range when step==0', function () {
-    assert.deepStrictEqual(range(0, 10, 0), matrix([]))
-    assert.deepStrictEqual(range(0, 10, 0, true), matrix([]))
+  it('should throw an error when step==0', function () {
+    assert.throws(function () { range(0, 10, 0) }, /Step must be non-zero/)
+    assert.throws(function () { range(0, 10, 0, true) }, /Step must be non-zero/)
   })
 
   it('should create an empty range when start and stop are equal', function () {
-    assert.deepStrictEqual(range(0, 0, 0), matrix([]))
-    assert.deepStrictEqual(range(0, 0, 0, true), matrix([]))
+    assert.deepStrictEqual(range(0, 0), matrix([]))
     assert.deepStrictEqual(range(1, 1, 2), matrix([]))
-    assert.deepStrictEqual(range(1, 1, 2, true), matrix([]))
     assert.deepStrictEqual(range('0:0'), matrix([]))
-    assert.deepStrictEqual(range('0:0:0'), matrix([]))
+    assert.deepStrictEqual(range('0:1:0'), matrix([]))
     assert.deepStrictEqual(range('1:2:1'), matrix([]))
     assert.deepStrictEqual(range('1:1:1'), matrix([]))
   })
 
+  it('should create an array with the end value when start and stop are equal and includeEnd=true', function () {
+    assert.deepStrictEqual(range(0, 0, true), matrix([0]))
+    assert.deepStrictEqual(range(1, 1, 2, true), matrix([1]))
+    assert.deepStrictEqual(range('0:0', true), matrix([0]))
+    assert.deepStrictEqual(range('1:1:1', true), matrix([1]))
+  })
+
   it('should output an array when setting matrix==="array"', function () {
     const math2 = math.create({
       matrix: 'Array'
@@ -84,9 +89,9 @@ describe('range', function () {
     assert.deepStrictEqual(range(bignumber(3), bignumber(1), bignumber(-1)), matrix([bignumber(3), bignumber(2)]))
   })
 
-  it('should create an empty range from bignumbers when step==0', function () {
-    assert.deepStrictEqual(range(bignumber(0), bignumber(10), bignumber(0)), matrix([]))
-    assert.deepStrictEqual(range(bignumber(0), bignumber(10), bignumber(0), true), matrix([]))
+  it('should throw an error from bignumbers when step==0', function () {
+    assert.throws(function () { range(bignumber(0), bignumber(10), bignumber(0)) }, /Step must be non-zero/)
+    assert.throws(function () { range(bignumber(0), bignumber(10), bignumber(0), true) }, /Step must be non-zero/)
   })
 
   it('should create a range with mixed numbers and bignumbers', function () {