Remove hardcode arguments to control() from control_ci()

Author: joeroe

NEWS.md

@@ -1,7 +1,6 @@
 # controller 0.0.0.9000
 
-* Adds `control()`, `control_ci()`, `control_fuzzy_boundary()` and
-  `control_fuzzy_encoding()`
+* Adds `control()`, `control_ci()`, and `control_fuzzy()`
 * Adds example dataset `colour_thesaurus`
 * Adds `read_fish()`
 * Adds a `NEWS.md` file to track changes to the package.

R/control.R

@@ -32,8 +32,10 @@
 #'   that couldn't be matched in `thesaurus`.
 #' @param coalesce If `TRUE` (the default), return only the closest matches in
 #'   `x`. If `FALSE`, return all matches.
-#' @param ... For `control_ci()` and `control_fuzzy`, other arguments passed to
-#'   `control()`.
+#' @param ... For `control_ci()` and `control_fuzzy()`, other arguments passed
+#'   to `control()`. This includes fuzzy matching options (`fuzzy_boundary`,
+#'   `fuzzy_encoding`) and output options (`quiet`, `warn_unmatched`,
+#'   `coalesce`).
 #'
 #' @return
 #' If `coalesce = TRUE` (the default), a vector the same length as `x` with
@@ -158,8 +160,7 @@ control <- function(x, thesaurus,
 #' @rdname control
 #' @export
 control_ci <- function(x, thesaurus, thesaurus_cols = c(1, 2), ...) {
-  control(x, thesaurus, thesaurus_cols, case_insensitive = TRUE,
-          fuzzy_boundary = FALSE, fuzzy_encoding = FALSE, ...)
+  control(x, thesaurus, thesaurus_cols, case_insensitive = TRUE, ...)
 }
 
 #' @rdname control

tests/testthat/test-control.R

@@ -104,3 +104,21 @@ test_that("control_fuzzy() combines all matching strategies", {
     c("foo bar", "foo bar", "baz")
   )
 })
+
+test_that("control_ci() accepts fuzzy matching arguments", {
+  df <- data.frame(canon = "foo bar", variant = "foo-bar")
+  expect_equal(
+    control_ci(c("foo bar", "foo_bar"), df,
+               fuzzy_boundary = TRUE, quiet = TRUE, warn_unmatched = FALSE),
+    c("foo bar", "foo bar")
+  )
+})
+
+test_that("control_ci() defaults to exact matching only", {
+  df <- data.frame(canon = "foo bar", variant = "foo-bar")
+  expect_equal(
+    control_ci(c("foo bar", "foo_bar"), df,
+               quiet = TRUE, warn_unmatched = FALSE),
+    c("foo bar", "foo_bar")
+  )
+})