test: migrate SupplementalGroupsYamlOverrideReproTest to JUnit 5

security-scan/CodeQL autobuild fails enforcer check-junit-imports on
JUnit 4 Assert/Before/Rule/Test imports. Match PodTemplateBuilderTest.

Signed-off-by: amarkdotdev <amarkdotdev@users.noreply.github.com>

Author: amarkdotdev

src/test/java/org/csanchez/jenkins/plugins/kubernetes/SupplementalGroupsYamlOverrideReproTest.java

@@ -1,39 +1,36 @@
 package org.csanchez.jenkins.plugins.kubernetes;
 
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
-import static org.junit.Assert.assertNull;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.mockito.Mockito.doReturn;
 import static org.mockito.Mockito.when;
 
 import io.fabric8.kubernetes.api.model.Pod;
 import io.fabric8.kubernetes.api.model.PodSecurityContext;
 import java.util.Arrays;
 import org.csanchez.jenkins.plugins.kubernetes.pod.yaml.Overrides;
-import org.junit.Before;
-import org.junit.Rule;
-import org.junit.Test;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
 import org.jvnet.hudson.test.JenkinsRule;
+import org.jvnet.hudson.test.junit.jupiter.WithJenkins;
 import org.mockito.Mock;
 import org.mockito.Spy;
-import org.mockito.junit.MockitoJUnit;
-import org.mockito.junit.MockitoRule;
+import org.mockito.junit.jupiter.MockitoExtension;
 
 /**
  * Verifies supplementalGroups from pod template UI/CasC fields survive yaml override merge.
  * Related to jenkinsci/kubernetes-plugin#2444.
  */
-public class SupplementalGroupsYamlOverrideReproTest {
+@WithJenkins
+@ExtendWith(MockitoExtension.class)
+class SupplementalGroupsYamlOverrideReproTest {
 
     private static final String AGENT_NAME = "jenkins-agent";
     private static final String AGENT_SECRET = "xxx";
     private static final String JENKINS_URL = "http://jenkins.example.com";
 
-    @Rule
-    public JenkinsRule r = new JenkinsRule();
-
-    @Rule
-    public MockitoRule mockitoRule = MockitoJUnit.rule();
+    private JenkinsRule r;
 
     @Spy
     private KubernetesCloud cloud = new KubernetesCloud("test");
@@ -44,8 +41,9 @@ public class SupplementalGroupsYamlOverrideReproTest {
     @Mock
     private KubernetesComputer computer;
 
-    @Before
-    public void setUp() {
+    @BeforeEach
+    void setUp(JenkinsRule rule) {
+        r = rule;
         when(slave.getKubernetesCloud()).thenReturn(cloud);
         doReturn(JENKINS_URL).when(cloud).getJenkinsUrlOrDie();
         when(computer.getName()).thenReturn(AGENT_NAME);
@@ -54,7 +52,7 @@ public void setUp() {
     }
 
     @Test
-    public void supplementalGroupsPresentWithoutRawYaml() throws Exception {
+    void supplementalGroupsPresentWithoutRawYaml() throws Exception {
         PodTemplate template = baseTemplate();
         Pod pod = new PodTemplateBuilder(template, slave).build();
 
@@ -64,7 +62,7 @@ public void supplementalGroupsPresentWithoutRawYaml() throws Exception {
     }
 
     @Test
-    public void supplementalGroupsPreservedWhenRawYamlOverrideIsUsed() throws Exception {
+    void supplementalGroupsPreservedWhenRawYamlOverrideIsUsed() throws Exception {
         PodTemplate template = baseTemplate();
         template.setYamlMergeStrategy(new Overrides());
         template.setYaml(
@@ -84,9 +82,9 @@ public void supplementalGroupsPreservedWhenRawYamlOverrideIsUsed() throws Except
         PodSecurityContext sc = pod.getSpec().getSecurityContext();
         assertNotNull(sc);
         assertEquals(
-                "expected supplementalGroups [5001, 5002] from pod template fields",
                 Arrays.asList(5001L, 5002L),
-                sc.getSupplementalGroups());
+                sc.getSupplementalGroups(),
+                "expected supplementalGroups [5001, 5002] from pod template fields");
     }
 
     private static PodTemplate baseTemplate() {