Skip to content

Upgrading parent in pom.xml from 1.20.1 to 1.23 and fixing checkstyle errors causes PMD errors. #96

@PeteKeller

Description

@PeteKeller
[INFO] Starting PMD validator
[ERROR] \src\it\it-decoloring\src\test\java\com\jcabi\log\MulticolorLayoutIntegrationTest.java[80-80]: Static fields should be accessed in a static way [CLASS_NAME.FIELD_NAME]. (StaticAccessToStaticFields)
[ERROR] \src\it\it-decoloring\src\test\java\com\jcabi\log\MulticolorLayoutIntegrationTest.java[91-91]: Static fields should be accessed in a static way [CLASS_NAME.FIELD_NAME]. (StaticAccessToStaticFields)
[ERROR] \src\it\it-decoloring\src\test\java\com\jcabi\log\MulticolorLayoutIntegrationTest.java[115-115]: Static fields should be accessed in a static way [CLASS_NAME.FIELD_NAME]. (StaticAccessToStaticFields)
[ERROR] \src\it\it-decoloring\src\test\java\com\jcabi\log\MulticolorLayoutIntegrationTest.java[126-126]: Static fields should be accessed in a static way [CLASS_NAME.FIELD_NAME]. (StaticAccessToStaticFields)
[ERROR] \src\it\it-decoloring\src\test\java\com\jcabi\log\MulticolorLayoutIntegrationTest.java[150-150]: Static fields should be accessed in a static way [CLASS_NAME.FIELD_NAME]. (StaticAccessToStaticFields)
[ERROR] \src\it\it-decoloring\src\test\java\com\jcabi\log\MulticolorLayoutIntegrationTest.java[161-161]: Static fields should be accessed in a static way [CLASS_NAME.FIELD_NAME]. (StaticAccessToStaticFields)
[ERROR] \src\it\it-decoloring\src\test\java\com\jcabi\log\MulticolorLayoutIntegrationTest.java[185-185]: Static fields should be accessed in a static way [CLASS_NAME.FIELD_NAME]. (StaticAccessToStaticFields)
[ERROR] \src\it\it-decoloring\src\test\java\com\jcabi\log\MulticolorLayoutIntegrationTest.java[196-196]: Static fields should be accessed in a static way [CLASS_NAME.FIELD_NAME]. (StaticAccessToStaticFields)
[ERROR] \src\main\java\com\jcabi\log\DecorsManager.java[89-118]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\main\java\com\jcabi\log\DomDecor.java[74-81]: Only field initialization or call to other constructors in a constructor. (ConstructorOnlyInitializesOrCallOtherConstructors)
[ERROR] \src\main\java\com\jcabi\log\ListDecor.java[60-71]: Only field initialization or call to other constructors in a constructor. (ConstructorOnlyInitializesOrCallOtherConstructors)
[ERROR] \src\main\java\com\jcabi\log\Logger.java[118-127]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\main\java\com\jcabi\log\Logger.java[135-137]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\main\java\com\jcabi\log\Logger.java[145-152]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\main\java\com\jcabi\log\Logger.java[161-166]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\main\java\com\jcabi\log\Logger.java[174-176]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\main\java\com\jcabi\log\Logger.java[184-191]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\main\java\com\jcabi\log\Logger.java[200-205]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\main\java\com\jcabi\log\Logger.java[213-215]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\main\java\com\jcabi\log\Logger.java[223-230]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\main\java\com\jcabi\log\Logger.java[239-244]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\main\java\com\jcabi\log\Logger.java[252-254]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\main\java\com\jcabi\log\Logger.java[262-269]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\main\java\com\jcabi\log\Logger.java[278-283]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\main\java\com\jcabi\log\Logger.java[291-293]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\main\java\com\jcabi\log\Logger.java[301-304]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\main\java\com\jcabi\log\Logger.java[312-314]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\main\java\com\jcabi\log\Logger.java[322-324]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\main\java\com\jcabi\log\Logger.java[333-335]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\main\java\com\jcabi\log\Logger.java[344-346]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\main\java\com\jcabi\log\Logger.java[355-369]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\main\java\com\jcabi\log\Logger.java[380-393]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\main\java\com\jcabi\log\Logger.java[405-429]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\main\java\com\jcabi\log\Logger.java[454-456]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\main\java\com\jcabi\log\MsDecor.java[68-72]: Only field initialization or call to other constructors in a constructor. (ConstructorOnlyInitializesOrCallOtherConstructors)
[ERROR] \src\main\java\com\jcabi\log\NanoDecor.java[69-73]: Only field initialization or call to other constructors in a constructor. (ConstructorOnlyInitializesOrCallOtherConstructors)
[ERROR] \src\main\java\com\jcabi\log\PreFormatter.java[83-83]: Only field initialization or call to other constructors in a constructor. (ConstructorOnlyInitializesOrCallOtherConstructors)
[ERROR] \src\main\java\com\jcabi\log\SecretDecor.java[60-64]: Only field initialization or call to other constructors in a constructor. (ConstructorOnlyInitializesOrCallOtherConstructors)
[ERROR] \src\main\java\com\jcabi\log\VerboseProcess.java[72-548]: Avoid doing field initialization outside constructor. (ConstructorShouldDoInitialization)
[ERROR] \src\main\java\com\jcabi\log\VerboseProcess.java[138-140]: Only field initialization or call to other constructors in a constructor. (ConstructorOnlyInitializesOrCallOtherConstructors)
[ERROR] \src\main\java\com\jcabi\log\VerboseProcess.java[141-143]: Only field initialization or call to other constructors in a constructor. (ConstructorOnlyInitializesOrCallOtherConstructors)
[ERROR] \src\main\java\com\jcabi\log\VerboseProcess.java[144-146]: Only field initialization or call to other constructors in a constructor. (ConstructorOnlyInitializesOrCallOtherConstructors)
[ERROR] \src\main\java\com\jcabi\log\VerboseProcess.java[147-152]: Only field initialization or call to other constructors in a constructor. (ConstructorOnlyInitializesOrCallOtherConstructors)
[ERROR] \src\main\java\com\jcabi\log\VerboseProcess.java[153-158]: Only field initialization or call to other constructors in a constructor. (ConstructorOnlyInitializesOrCallOtherConstructors)
[ERROR] \src\main\java\com\jcabi\log\VerboseProcess.java[102-102]: Static fields should be accessed in a static way [CLASS_NAME.FIELD_NAME]. (StaticAccessToStaticFields)
[ERROR] \src\main\java\com\jcabi\log\VerboseProcess.java[216-216]: Static fields should be accessed in a static way [CLASS_NAME.FIELD_NAME]. (StaticAccessToStaticFields)
[ERROR] \src\main\java\com\jcabi\log\VerboseThreads.java[89-243]: Avoid doing field initialization outside constructor. (ConstructorShouldDoInitialization)
[ERROR] \src\test\java\com\jcabi\log\AbstractDecorTest.java[91-91]: Only field initialization or call to other constructors in a constructor. (ConstructorOnlyInitializesOrCallOtherConstructors)
[ERROR] \src\test\java\com\jcabi\log\LineNumberTest.java[63-63]: Static fields should be accessed in a static way [CLASS_NAME.FIELD_NAME]. (StaticAccessToStaticFields)
[ERROR] \src\test\java\com\jcabi\log\ListDecorTest.java[68-84]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\test\java\com\jcabi\log\MsDecorTest.java[68-85]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\test\java\com\jcabi\log\NanoDecorTest.java[69-96]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\test\java\com\jcabi\log\ObjectDecorTest.java[68-87]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\test\java\com\jcabi\log\ParseableInformationTest.java[52-58]: Avoid using Plain JUnit assertions (ProhibitPlainJunitAssertionsRule)
[ERROR] \src\test\java\com\jcabi\log\ParseableInformationTest.java[64-81]: Avoid using Plain JUnit assertions (ProhibitPlainJunitAssertionsRule)
[ERROR] \src\test\java\com\jcabi\log\ParseableLevelInformationTest.java[52-58]: Avoid using Plain JUnit assertions (ProhibitPlainJunitAssertionsRule)
[ERROR] \src\test\java\com\jcabi\log\ParseableLevelInformationTest.java[65-82]: Avoid using Plain JUnit assertions (ProhibitPlainJunitAssertionsRule)
[ERROR] \src\test\java\com\jcabi\log\ParseableLevelInformationTest.java[89-101]: Avoid using Plain JUnit assertions (ProhibitPlainJunitAssertionsRule)
[ERROR] \src\test\java\com\jcabi\log\SecretDecorTest.java[69-80]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\test\java\com\jcabi\log\SizeDecorTest.java[69-89]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\test\java\com\jcabi\log\TextDecorTest.java[72-83]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\test\java\com\jcabi\log\TextDecorTest.java[77-77]: The String literal "simple text" appears 2 times in this file; the first occurrence is on line 77 (AvoidDuplicateLiterals)
[ERROR] \src\test\java\com\jcabi\log\TypeDecorTest.java[67-76]: Public static methods are prohibited. (ProhibitPublicStaticMethods)
[ERROR] \src\test\java\com\jcabi\log\UnitTestAppender.java[46-80]: Avoid doing field initialization outside constructor. (ConstructorShouldDoInitialization)
[ERROR] \src\test\java\com\jcabi\log\UnitTestAppender.java[60-60]: Only field initialization or call to other constructors in a constructor. (ConstructorOnlyInitializesOrCallOtherConstructors)
[ERROR] \src\test\java\com\jcabi\log\VerboseProcessTest.java[105-105]: The String literal "/bin/bash" appears 2 times in this file; the first occurrence is on line 105 (AvoidDuplicateLiterals)
[ERROR] \src\test\java\com\jcabi\log\VerboseProcessTest.java[130-130]: The String literal "No such file or directory" appears 2 times in this file; the first occurrence is on line 130 (AvoidDuplicateLiterals)
[ERROR] \src\test\java\com\jcabi\log\VerboseProcessTest.java[326-326]: The String literal "Error reading from process stream" appears 2 times in this file; the first occurrence is on line 326 (AvoidDuplicateLiterals)
[ERROR] \src\test\java\com\jcabi\log\VerboseProcessTest.java[121-121]: The String literal "cat" appears 3 times in this file; the first occurrence is on line 121 (AvoidDuplicateLiterals)
[ERROR] \src\test\java\com\jcabi\log\VerboseProcessTest.java[200-200]: The String literal "intended only for internal configuration" appears 2 times in this file; the first occurrence is on line 200 (AvoidDuplicateLiterals)
[ERROR] \src\test\java\com\jcabi\log\VerboseProcessTest.java[121-121]: The String literal "/non-existing-file.txt" appears 2 times in this file; the first occurrence is on line 121 (AvoidDuplicateLiterals)
[ERROR] \src\test\java\com\jcabi\log\VerboseProcessTest.java[85-85]: The String literal "echo" appears 2 times in this file; the first occurrence is on line 85 (AvoidDuplicateLiterals)
[ERROR] \src\test\java\com\jcabi\log\VerboseProcessTest.java[193-193]: The String literal "IllegalArgumentException expected" appears 2 times in this file; the first occurrence is on line 193 (AvoidDuplicateLiterals)
[INFO] Read our quality policy: http://www.qulice.com/quality.html
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:17 min
[INFO] Finished at: 2017-03-18T11:55:12-04:00
[INFO] Final Memory: 51M/513M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.qulice:qulice-maven-plugin:0.17.1:check (jcabi-check) on project jcabi-log: Failure: 73 PMD violations (see log above) -> [Help 1]

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions