Add logger name label to prometheus logging metrics

janos · janos · commit f926c214e272 · 2023-08-05T00:02:12.000+02:00
diff --git a/logging/prometheus.go b/logging/prometheus.go
@@ -45,15 +45,18 @@ func NewMetrics(options *MetricsOptions) (c *Metrics) {
 			Name:      options.Name,
 			Help:      options.Help,
 		},
-		[]string{"level"},
+		[]string{"logger", "level"},
 	)
 	return &Metrics{
 		vector: vector,
 	}
 }
 
-func (c *Metrics) Inc(level slog.Level) {
-	c.vector.WithLabelValues(level.String()).Inc()
+func (c *Metrics) Inc(loggerName string, level slog.Level) {
+	c.vector.With(prometheus.Labels{
+		"logger": loggerName,
+		"level":  level.String(),
+	}).Inc()
 }
 
 // Metrics returns all Prometheus metrics that should be registered.

Original file line number	Diff line number	Diff line change
`@@ -45,15 +45,18 @@ func NewMetrics(options MetricsOptions) (c Metrics) {`
`45`	`45`	`Name: options.Name,`
`46`	`46`	`Help: options.Help,`
`47`	`47`	`},`
`48`		`- []string{"level"},`
	`48`	`+ []string{"logger", "level"},`
`49`	`49`	`)`
`50`	`50`	`return &Metrics{`
`51`	`51`	`vector: vector,`
`52`	`52`	`}`
`53`	`53`	`}`
`54`	`54`
`55`		`-func (c *Metrics) Inc(level slog.Level) {`
`56`		`- c.vector.WithLabelValues(level.String()).Inc()`
	`55`	`+func (c *Metrics) Inc(loggerName string, level slog.Level) {`
	`56`	`+ c.vector.With(prometheus.Labels{`
	`57`	`+ "logger": loggerName,`
	`58`	`+ "level": level.String(),`
	`59`	`+ }).Inc()`
`57`	`60`	`}`
`58`	`61`
`59`	`62`	`// Metrics returns all Prometheus metrics that should be registered.`