TCK: old-tck/run/pom.xml appears to be hardwired to glassfish

[robertpatrick]

Challenged tests
Everything under old-tck/run seems to be hardwired to depend on glassfish.

TCK Version
Jakarta Faces TCK 4.1.1

Description
old-tck/run/pom.xml includes hardwired dependencies and references to files in a glassfish distribuion.

Additional context
Are we allowed to change the pom?

[arjantijms]

old-tck/run/pom.xml and the main pom..xml are indeed what we call the "runner poms", and they can (should) be modified for the vendor implementation.

The guide is bit cryptic about it, we just say:

4.2 Configuring Your Environment to Run the TCK Against the Vendor Implementation (VI)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Follow the instructions above, customized as necessary for the
Vendor implementation.
A custom deployment handler will need to be created for the
Vendor implementation.

The main pom.xml contains several profiles per target implementation, but old-tck/run/pom.xml does not. This was done since all vendors already had their own ways / mechanisms to run the "old" TCK (which is the TCK almost literally as has existed since ~2005 for Faces).

The entire concept of old tck in this form was meant to be transitional, but unfortunately nobody ever found the time to convert them.

TLDR; yes, you have to edit both pom.xml files to allow the TCK to run against your product.