Remove command: /review-alignment update agent robot-business-analyst

[jabrena]

User Story: Remove /review-alignment command and update robot-business-analyst

As a Plinth toolkit maintainer
I want to remove the /review-alignment command from the command inventory and update the robot-business-analyst agent definition accordingly
So that the command set and agent responsibilities stay aligned with the actual required workflow, without an unused command and a stale agent mission referencing it

Notes

The confirmed workflow does not require /review-alignment:

/update-issue
/explore-problem
/create-acceptance-criteria
/create-spec
/explore-design

Evidence in the repository:

• plinth-commands-generator/src/main/resources/commands/review-alignment.xml defines the /review-alignment command with <agent>robot-business-analyst</agent> and is registered in plinth-commands-generator/src/main/resources/commands.xml.
• plinth-agents-generator/src/main/resources/agents/robot-business-analyst.xml includes a "3. Review alignment and readiness" mission in its <goal> that backs this command.

Scope of work:

• Remove the review-alignment.xml command source and its registration in commands.xml.
• Update robot-business-analyst.xml to remove the "Review alignment and readiness" mission (and any related references, e.g. in <output-format> or <constraints>, that exist solely to support it).
• Regenerate any derived command/agent/skill output affected by this removal, per the project's generator workflow.

INVEST Validation

• Independent: This change is self-contained to the command inventory and one agent definition; it does not depend on other unfinished stories.
• Negotiable: The exact set of robot-business-analyst goal/output-format lines to prune can be refined during implementation while preserving the intent of dropping the alignment-review capability.
• Valuable: Removes an unnecessary command and keeps the agent's responsibilities truthful to the supported workflow, reducing maintenance surface and contributor confusion.
• Estimable: The affected files are identified (review-alignment.xml, commands.xml, robot-business-analyst.xml), so effort can be sized from current evidence.
• Small: Limited to deleting one command source and editing one agent source, fitting within a single iteration.
• Testable: Completion is verified when /review-alignment no longer appears in the command inventory or generated output, and robot-business-analyst's description/goal no longer references alignment/readiness review.

[jabrena]

Functional Specification

Problem Framing

Problem statement: The command inventory contains /review-alignment (owned by robot-business-analyst), and the robot-business-analyst agent definition carries a "Review alignment and readiness" mission implementing it, even though the maintainer-confirmed required workflow — /update-issue, /explore-problem, /create-acceptance-criteria, /create-spec, /explore-design — does not include it.

Current state:

• plinth-commands-generator/src/main/resources/commands/review-alignment.xml defines /review-alignment, registered in commands.xml, with <agent>robot-business-analyst</agent>.
• plinth-agents-generator/src/main/resources/agents/robot-business-analyst.xml contains a "3. Review alignment and readiness" mission in its <goal> backing this command.
• /review-alignment is additionally referenced in test sources (CommandIndexesTest.java, CommandFrontmatterTest.java, review-alignment.feature), the skill pipeline (skills.xml, skill-references/004-commands-installation.xml), and documentation (GETTING-STARTED-WORKFLOWS.md/_ES/_ZH, GETTING-STARTED-AGENTS.md/_ES/_ZH, INVENTORY-COMMANDS-JAVA.md).

Desired state: The command inventory and robot-business-analyst agent definition contain only commands/missions required by the confirmed workflow; no living source, test, generated skill, or documentation artifact still describes /review-alignment as an available command.

Stakeholders: Repo maintainer (issue author, workflow owner), contributors invoking Plinth commands, the skills-generator pipeline that packages commands into distributable skills, and documentation readers relying on GETTING-STARTED-* guides.

Success criteria: /review-alignment no longer appears in commands.xml, generated command/skill output, or documentation; robot-business-analyst.xml's goal/output-format no longer references alignment/readiness review; ./mvnw clean verify -pl plinth-commands-generator -pl plinth-agents-generator -pl plinth-skills-generator -am passes.

Root Cause Analysis

Five Whys:

1. Why does an unused command still exist? Because /review-alignment was built with a supporting mission in robot-business-analyst, and the workflow list confirmed in this issue doesn't include it.
2. Why wasn't it excluded earlier? No evidence in the issue of when/why the workflow list was finalized without it — flagged as an open unknown rather than guessed.
3. Why does its removal touch so many files? A single command is duplicated across three generator modules (commands, agents, skills) plus dedicated tests and trilingual docs, with no single source of truth for "is this command part of the active workflow."

Stopped here — further "why" steps would require guessing at historical intent.

Fishbone (plausible dimensions):

• Process: no decommissioning step exists when a workflow list changes.
• Technology: command/agent/skill definitions are hand-duplicated across three Maven modules with no cross-reference check.
• Documentation: a three-language doc set (_ES, _ZH) must be kept in sync manually per CLAUDE.md.

Constraint: The limiting factor is the lack of an automated check tying the "confirmed workflow" list to what's actually registered in commands.xml/agents.xml — nothing currently fails CI when a command exists outside the intended workflow.

Assumption Analysis

Assumptions (believed true, not yet verified):

• Full removal (confirmed scope) includes tests, the skills pipeline, and all three documentation languages, but not immutable OpenSpec archive history under documentation/openspec/changes/archive/** (archived changes are point-in-time records, not living docs).
• The living OpenSpec specs (documentation/openspec/specs/analysis-design-commands/spec.md, documentation/openspec/specs/implement-spec-command/spec.md) describe current expected behavior and should be updated for consistency, since they are not archived.
• No other command or agent besides robot-business-analyst depends on the "Review alignment and readiness" mission text.

Unknowns:

• Whether CommandIndexesTest.java or CommandFrontmatterTest.java assert a specific command count or enumerate commands by name in a way that fails once /review-alignment is removed (rather than just referencing it incidentally).
• Whether regenerating .agents/skills after removal changes output that other tests or the acceptance-tests-prompts-skills.md inventory depend on.

Validation plan:

• Grep review-alignment and Review alignment and readiness across all non-archived sources after the change; expect zero hits outside documentation/openspec/changes/archive/**.
• Run ./mvnw clean verify -pl plinth-commands-generator -pl plinth-agents-generator -pl plinth-skills-generator -am to surface test breakage.
• Regenerate local skills (./mvnw clean install -pl plinth-skills-generator -am) and diff .agents/skills output for unexpected drift.

Context Mapping

Existing systems: plinth-commands-generator (owns commands.xml + review-alignment.xml), plinth-agents-generator (owns robot-business-analyst.xml), plinth-skills-generator (consumes both to produce skills/ and .agents/skills); site-generator/docs/ is not implicated (no hits found there).

Integrations: plinth-skills-generator reads commands.xml/agents.xml via XInclude/XSLT to build the 004-commands-installation skill assets; documentation guides are manually maintained in parallel (not generated from XML), so they need direct edits, not regeneration.

Ownership: Single maintainer-owned repository; no cross-team ownership boundary — all affected modules are within this repository.

External dependencies: skill-check@latest and cisco-ai-skill-scanner validate generated skills/ output in CI; no third-party service depends on /review-alignment specifically.

Quality Attribute Discovery

1. Consistency/Correctness (highest priority) — the change touches roughly ten living files across three modules plus docs; a missed reference leaves a dangling mention of a removed command, directly contradicting the desired state.
2. Maintainability — reducing command/mission surface to only workflow-required entries is the explicit point of this issue.
3. Testability/Verifiability — existing generator test suites (CommandIndexesTest, CommandFrontmatterTest, the review-alignment.feature) must be updated/removed rather than left failing or falsely passing.
4. Localization consistency — _ES/_ZH doc variants must not drift from the English source per CLAUDE.md.

This stops at the discovery list — no architecture decision is made here.

[jabrena]

Acceptance Criteria

Feature: Remove the /review-alignment command and its supporting agent mission
  The confirmed workflow (/update-issue, /explore-problem, /create-acceptance-criteria,
  /create-spec, /explore-design) does not include /review-alignment. The command inventory
  and the robot-business-analyst agent definition must no longer offer or describe it, and
  every living artifact that referenced it must be updated in the same change.

  Scenario: Command source is removed from the inventory
    Given the confirmed workflow does not include the /review-alignment command
    When a contributor inspects the command inventory
    Then commands.xml no longer registers review-alignment.xml
    And plinth-commands-generator/src/main/resources/commands/review-alignment.xml no longer exists

  Scenario: Supporting mission is removed from the owning agent
    Given the robot-business-analyst agent definition
    When a contributor inspects its goal content
    Then the goal no longer contains a "Review alignment and readiness" mission
    And its output-format and constraints no longer reference alignment or readiness review

  Scenario: Generated skill output no longer describes the removed command
    Given the skills pipeline builds skill assets from commands.xml and agents.xml
    When the skills generator is rerun
    Then the generated skill-references/004-commands-installation assets no longer include review-alignment content
    And skills.xml no longer references review-alignment

  Scenario: Trilingual documentation stays in sync
    Given GETTING-STARTED-WORKFLOWS and GETTING-STARTED-AGENTS guides exist in English, Spanish, and Chinese
    When the /review-alignment command is removed
    Then none of the EN, ES, or ZH guide variants describe /review-alignment as an available command

  Scenario: Archived OpenSpec history is preserved unchanged
    Given documentation/openspec/changes/archive contains historical records that mention review-alignment
    When the removal change is made
    Then the archived files remain unchanged as historical record

  Scenario: No stale references remain outside archived history
    Given the removal change is complete
    When a contributor searches the repository for "review-alignment" outside documentation/openspec/changes/archive
    Then zero matches are found

  Scenario: Affected modules build and test successfully
    Given the plinth-commands-generator, plinth-agents-generator, and plinth-skills-generator modules
    When a contributor runs "./mvnw clean verify -pl plinth-commands-generator -pl plinth-agents-generator -pl plinth-skills-generator -am"
    Then the build completes successfully with no test referencing the removed command