No conn parameter at line 45 in bcp.r - requires presence of getOption('sqsrvr.database')

[sch56]

Hi Simon
This package is just what I need for a project, however I get an error
Error in t[3] <- getOption("sqlservr.db_database") : replacement has length zero

This appears to be due to line 45 in bcp.r not including the second parameter conn

For now I am ensuring that options('sqlservr.db_database' = ) is included in the code before using db_bcp,
but probably good to consider this in the source.

[sch56]

On further investigation, I have worked out the use of options('sqlservr.xxxx'). This appears to be a pre-requisite for this function to work with a database on a remote server.
However I have a problem with POSIXct data types. Where these are present in the source table then the paste_no_na function fails as POSIXct errors when set to "".

I have found the following works (whether done in your code (at line 123 in bcp.r), or before sending the data to your function

#Convert any POSIXct columns to character representation
POSIXcols <- names(which(sapply(sapply(data, class), function(x) 'POSIXct' %in% x)))
if (length(POSIXcols) > 0) data[,(POSIXcols) := (lapply(.SD, as.character)), .SDcols = POSIXcols]

There may be a more elegant way of converting the POSIX columns to character, but the result works when the target columns in SQL are datetime.
A limitation with this is the application of time zone information attributes in the POSIXct data. This is lost when converting as.character.
If I find ways of addressing this I will post the info here.