Fix for MC-122477 causing only backspace to work in textfields on linux (closes #77)

Author: isXander

changelogs/1.10.0.md

@@ -3,6 +3,10 @@
 - [MC-55347](https://bugs.mojang.com/browse/MC-55347) - Title with long duration shows in other world
 - [MC-26757](https://bugs.mojang.com/browse/MC-26757) - Large item tooltips can get cut off at the edges of the screen *(fabric only)*
 
+**Rebugify no more!**
+
+- Fix [MC-122477](https://bugs.mojang.com/browse/MC-122477) preventing some linux users from typing any characters in chat boxes.
+
 **Misc**
 
 - On Quilt, require beta 15 or later because there is a crucial bug fix.

common/src/main/java/cc/woverflow/debugify/fixes/mc122477/KeyboardPollCounter.java

@@ -0,0 +1,24 @@
+package cc.woverflow.debugify.fixes.mc122477;
+
+public class KeyboardPollCounter {
+    private static int count = 0;
+    private static boolean requiresCount = false;
+
+    public static void poll() {
+        if (requiresCount)
+            count++;
+    }
+
+    public static void startCounting() {
+        requiresCount = true;
+    }
+
+    public static void stopCountingAndReset() {
+        requiresCount = false;
+        count = 0;
+    }
+
+    public static int getCount() {
+        return count;
+    }
+}

common/src/main/java/cc/woverflow/debugify/mixins/basic/client/mc122477/RenderSystemMixin.java

@@ -0,0 +1,20 @@
+package cc.woverflow.debugify.mixins.basic.client.mc122477;
+
+import cc.woverflow.debugify.fixes.BugFix;
+import cc.woverflow.debugify.fixes.FixCategory;
+import cc.woverflow.debugify.fixes.mc122477.KeyboardPollCounter;
+import com.mojang.blaze3d.systems.RenderSystem;
+import net.minecraft.util.Util;
+import org.spongepowered.asm.mixin.Mixin;
+import org.spongepowered.asm.mixin.injection.At;
+import org.spongepowered.asm.mixin.injection.Inject;
+import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
+
+@BugFix(id = "MC-122477", category = FixCategory.BASIC, env = BugFix.Env.CLIENT)
+@Mixin(RenderSystem.class)
+public class RenderSystemMixin {
+    @Inject(method = "flipFrame", at = @At(value = "INVOKE", target = "Lorg/lwjgl/glfw/GLFW;glfwPollEvents()V"))
+    private static void onPollEvents(long window, CallbackInfo ci) {
+        KeyboardPollCounter.poll();
+    }
+}

common/src/main/java/cc/woverflow/debugify/mixins/basic/client/mc122477/TextFieldWidgetMixin.java

@@ -2,7 +2,10 @@
 
 import cc.woverflow.debugify.fixes.BugFix;
 import cc.woverflow.debugify.fixes.FixCategory;
+import cc.woverflow.debugify.fixes.mc122477.KeyboardPollCounter;
+import net.minecraft.client.font.TextRenderer;
 import net.minecraft.client.gui.widget.TextFieldWidget;
+import net.minecraft.text.Text;
 import net.minecraft.util.Util;
 import org.spongepowered.asm.mixin.Mixin;
 import org.spongepowered.asm.mixin.Unique;
@@ -14,18 +17,19 @@
 @BugFix(id = "MC-122477", category = FixCategory.BASIC, env = BugFix.Env.CLIENT)
 @Mixin(TextFieldWidget.class)
 public class TextFieldWidgetMixin {
-    @Unique
-    private int debugify$ticks = 0;
-
-    @Inject(method = "tick", at = @At("HEAD"))
-    private void onTick(CallbackInfo ci) {
-        if (debugify$ticks < 2)
-            debugify$ticks++;
+    @Inject(method = "<init>(Lnet/minecraft/client/font/TextRenderer;IIIILnet/minecraft/client/gui/widget/TextFieldWidget;Lnet/minecraft/text/Text;)V", at = @At("RETURN"))
+    private void startPolling(TextRenderer textRenderer, int x, int y, int width, int height, TextFieldWidget copyFrom, Text text, CallbackInfo ci) {
+        KeyboardPollCounter.startCounting();
     }
 
     @Inject(method = "charTyped", at = @At("HEAD"), cancellable = true)
     private void onCharTyped(char chr, int modifiers, CallbackInfoReturnable<Boolean> cir) {
-        if (debugify$ticks <= 1 && Util.getOperatingSystem() == Util.OperatingSystem.LINUX)
-            cir.setReturnValue(true);
+        if (Util.getOperatingSystem() == Util.OperatingSystem.LINUX) {
+            if (KeyboardPollCounter.getCount() == 1)
+                cir.setReturnValue(true);
+
+            if (KeyboardPollCounter.getCount() >= 1)
+                KeyboardPollCounter.stopCountingAndReset();
+        }
     }
 }

common/src/main/resources/debugify-common.mixins.json

@@ -13,6 +13,7 @@
     "basic.client.mc116379.FishingBobberEntityRendererMixin",
     "basic.client.mc121772.MouseMixin",
     "basic.client.mc122477.TextFieldWidgetMixin",
+    "basic.client.mc122477.RenderSystemMixin",
     "basic.client.mc122627.CommandSuggestorMixin",
     "basic.client.mc123739.ClientRecipeBookMixin",
     "basic.client.mc127970.HeldItemRendererMixin",
@@ -43,12 +44,12 @@
     "basic.client.mc53312.IllagerEntityModelMixin",
     "basic.client.mc53312.VillagerResemblingModelMixin",
     "basic.client.mc53312.ZombieVillagerEntityModelMixin",
+    "basic.client.mc55347.InGameHudMixin",
     "basic.client.mc79545.InGameHudMixin",
     "basic.client.mc80859.HandledScreenMixin",
     "basic.client.mc93384.LivingEntityMixin",
     "gameplay.client.mc12829.LivingEntityMixin",
-    "gameplay.client.mc12829.PlayerEntityMixin",
-    "basic.client.mc55347.InGameHudMixin"
+    "gameplay.client.mc12829.PlayerEntityMixin"
   ],
   "mixins": [
     "basic.server.mc100991.FishingBobberEntityMixin",