Skip to content

Commit 12e6f6c

Browse files
Max191claude
andcommitted
[NFC] Add comment explaining unused vectorSizes/scalableDims in im2col
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Max Dawkins <max.dawkins@gmail.com>
1 parent 7bccad5 commit 12e6f6c

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

compiler/src/iree/compiler/Codegen/Interfaces/VectorizableOpInterface.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1149,10 +1149,12 @@ static Value computeIm2colPaddingMask(
11491149
return vector::CreateMaskOp::create(b, loc, vecI1Type, validSize);
11501150
}
11511151

1152+
// Im2col vectorization computes its own vector width via
1153+
// chooseDimToVectorize() based on the op's layout and contiguity
1154+
// constraints, rather than using the driver-provided vectorSizes.
11521155
struct Im2colOpVectorizationModel
11531156
: public VectorizableOpInterface::ExternalModel<Im2colOpVectorizationModel,
11541157
IREE::LinalgExt::Im2colOp> {
1155-
11561158
bool isVectorizable(Operation *op, ArrayRef<int64_t> vectorSizes,
11571159
ArrayRef<bool> scalableDims,
11581160
DictionaryAttr options) const {

0 commit comments

Comments
 (0)