On being more idiomatic: listing more "forbidden" calls

[paulo-ferraz-oliveira]

Think about adding to no_call or somewhere similar:

• maps:put/3
• maps:update/3
• string:equal/2
• string:concat/2
• string:is_empty/1
• lists:append/2
• ets:lookup/2
• lists:map/2

As better alternatives exist for these, and more idiomatic, too.

[elbrujohalcon]

Yeah… Some of this stuff is also covered in some elp lintings. Particularly the ones from the maps module raise warnings saying something like "Prefer map syntax over functions in the maps module"

[elbrujohalcon]

Also note that there are times in which, for instance, lists:map/1 is in fact more idiomatic than a list comprehension: inaka/elvis#568 (comment)

Maybe this requires a new rule that can be smart enough to detect specific cases where each function is more idiomatic.