Skip to content

Commit 2f9378f

Browse files
authored
Merge pull request #66 from imdangg/feat/member_fix
[Fix] 로그인 보완
2 parents cb81aff + f634c7b commit 2f9378f

File tree

1 file changed

+8
-9
lines changed
  • member-service/member-domain/member-application-service/src/main/java/com/project/imdang/member/service/domain/handler/auth

1 file changed

+8
-9
lines changed

member-service/member-domain/member-application-service/src/main/java/com/project/imdang/member/service/domain/handler/auth/OAuthLoginCommandHandler.java

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -40,16 +40,15 @@ public LoginResponse login(OAuthLoginCommand loginCommand) {
4040

4141
// 1. 로그인
4242
// TODO - REVIEW
43-
boolean isJoined = false;
4443
Optional<Member> optional = memberRepository.findByOAuthIdAndOAuthType(oAuthInfo.getId(), oAuthInfo.getOAuthType());
45-
Member member;
46-
if (optional.isEmpty()) {
47-
member = memberDomainService.createMember(oAuthInfo.getId(), oAuthInfo.getOAuthType());
48-
saveMember(member);
49-
} else {
50-
member = optional.get();
51-
isJoined = (member.getNickname() != null);
52-
}
44+
// 지워지지 않은 사용자라면 가져오고, 아니라면 새로 생성
45+
Member member = optional.filter(m -> m.getIsDeleted().equals(Boolean.FALSE))
46+
.orElseGet(() -> {
47+
Member createdMember = memberDomainService.createMember(oAuthInfo.getId(), oAuthInfo.getOAuthType());
48+
saveMember(createdMember);
49+
return createdMember;
50+
});
51+
boolean isJoined = member.getNickname() != null;
5352

5453
// 2. 토큰 생성
5554
TokenResponse tokenResponse = tokenRequestHandler.generate(member);

0 commit comments

Comments
 (0)