Bugfixes

- Increase number of keyboards to 5, complex / weird descriptors were seen to exhaust the limit
- Avoid increasing num_keyboards multiple times for a single report_id (seen with Apple keyboard)

Author: Hrvoje Cavrak

CMakeLists.txt

@@ -3,7 +3,7 @@ cmake_minimum_required(VERSION 3.6)
 ## Version Configuration.
 ## Define e.g. 0.72 as major 0 and minor 72
 set(VERSION_MAJOR 0)
-set(VERSION_MINOR 73)
+set(VERSION_MINOR 77)
 
 ## Release Type Selection
 option(DH_DEBUG "Build a debug version" OFF)

src/hid_report.c

@@ -114,9 +114,11 @@ void handle_keyboard_descriptor_values(report_val_t *src, report_val_t *dst, hid
         keyboard->nkro    = *src;
     }
 
-    /* We found a keyboard on this interface. */
-    keyboard->is_found = true;
-    iface->num_keyboards++;
+    /* We found a keyboard on this interface for a specific report id. */
+    if (!keyboard->is_found) {
+        keyboard->is_found = true;
+        iface->num_keyboards++;
+    }
 }
 
 void handle_buttons(report_val_t *src, report_val_t *dst, hid_interface_t *iface) {

src/include/hid_parser.h

@@ -24,7 +24,7 @@
 #define MAX_INTERFACES              12  // Per device; allows for complex devices like QMK
 #define MAX_KEYS                    32
 #define MAX_REPORTS                 24
-#define MAX_KEYBOARDS               3
+#define MAX_KEYBOARDS               5
 #define MAX_SYS_BUTTONS             8
 #define PRIMARY_KEYBOARD            0
 /*==============================================================================