fix: Horde_Registry_Hordeconfig upgrade ReturnTypeWillChange to actual PHP8 return types

Author: ralflang

lib/Horde/Config.php

@@ -158,7 +158,7 @@ public function checkVersions()
     public function configFile()
     {
         if (defined('HORDE_CONFIG_BASE')) {
-            $path = HORDE_CONFIG_BASE;
+            $path = HORDE_CONFIG_BASE . DIR_SEPARATOR . $this->_app;
         } else {
             $path = $GLOBALS['registry']->get('fileroot', $this->_app) . '/config';
         }
@@ -307,7 +307,7 @@ public function writePHPConfig($formvars, &$php = null)
     {
         $php = $this->generatePHPConfig($formvars);
         if (defined('HORDE_CONFIG_BASE')) {
-            $path = HORDE_CONFIG_BASE;
+            $path = HORDE_CONFIG_BASE . DIR_SEPARATOR . $this->_app;
         } else {
             $path = $GLOBALS['registry']->get('fileroot', $this->_app) . '/config';
         }

lib/Horde/Registry/Hordeconfig.php

@@ -87,8 +87,7 @@ protected function _load($offset)
 
     /**
      */
-    #[\ReturnTypeWillChange]
-    public function offsetExists($offset)
+    public function offsetExists($offset): bool
     {
         $this->_load($offset);
         return isset($this->_config[$offset]);
@@ -104,17 +103,15 @@ public function offsetGet($offset)
             ?? null;
     }
 
-    #[\ReturnTypeWillChange]
-    public function offsetSet($offset, $value)
+    public function offsetSet($offset, $value): void
     {
         $this->_load($offset);
         $this->_config[$offset] = $value;
     }
 
     /**
      */
-    #[\ReturnTypeWillChange]
-    public function offsetUnset($offset)
+    public function offsetUnset($offset): void
     {
         $this->_load($offset);
         unset($this->_config[$offset]);
@@ -124,8 +121,7 @@ public function offsetUnset($offset)
 
     /**
      */
-    #[\ReturnTypeWillChange]
-    public function count()
+    public function count(): int
     {
         /* Return non-zero to ensure a count() calls returns true. */
         return 1;