MEGA TEST COVERAGE

Author: jeeftor

tests/components/openaq/test_config_flow.py

@@ -23,6 +23,7 @@
 import pytest
 
 from homeassistant import config_entries
+from homeassistant.components.openaq.config_flow import OpenAQLocationFlowData
 from homeassistant.components.openaq.const import (
     CONF_LIMIT,
     CONF_LOCATION_ID,
@@ -265,6 +266,38 @@ async def test_location_subentry_map_flow_sorts_by_sensor_count_before_distance(
     ]
 
 
+async def test_location_subentry_map_flow_labels_unknown_distance(
+    hass: HomeAssistant,
+    mock_openaq_client: AsyncMock,
+    mock_config_entry: MockConfigEntry,
+) -> None:
+    """Test map search labels locations with invalid distances."""
+    mock_config_entry.add_to_hass(hass)
+    mock_openaq_client.locations.list.return_value = make_response(
+        [make_location(location_id=9999, distance=True)]
+    )
+    result = await hass.config_entries.subentries.async_init(
+        (mock_config_entry.entry_id, "location"),
+        context={"source": config_entries.SOURCE_USER},
+    )
+
+    result = await hass.config_entries.subentries.async_configure(
+        result["flow_id"],
+        {
+            ATTR_LOCATION: {ATTR_LATITUDE: 35.1, ATTR_LONGITUDE: -106.6},
+            CONF_RADIUS: 5000,
+            CONF_LIMIT: 10,
+        },
+    )
+
+    assert _get_select_options(result) == [
+        SelectOptionDict(
+            value="9999",
+            label="Del Norte, Albuquerque - 1 sensor: PM2.5 - unknown distance",
+        )
+    ]
+
+
 async def test_location_subentry_map_flow_limits_to_top_five_locations(
     hass: HomeAssistant,
     mock_openaq_client: AsyncMock,
@@ -465,6 +498,41 @@ async def test_location_subentry_invalid_map_location_id(
     assert result["errors"] == {"base": "no_locations_found"}
 
 
+async def test_location_subentry_invalid_map_sensors(
+    hass: HomeAssistant,
+    mock_openaq_client: AsyncMock,
+    mock_config_entry: MockConfigEntry,
+) -> None:
+    """Test map search ignores locations without sensor lists."""
+    mock_config_entry.add_to_hass(hass)
+    mock_openaq_client.locations.list.return_value = make_response(
+        [SimpleNamespace(id=9999, name="Bad", locality="Albuquerque", sensors=None)]
+    )
+    result = await hass.config_entries.subentries.async_init(
+        (mock_config_entry.entry_id, "location"),
+        context={"source": config_entries.SOURCE_USER},
+    )
+    result = await hass.config_entries.subentries.async_configure(
+        result["flow_id"],
+        {
+            ATTR_LOCATION: {ATTR_LATITUDE: 35.1, ATTR_LONGITUDE: -106.6},
+            CONF_RADIUS: 5000,
+            CONF_LIMIT: 10,
+        },
+    )
+
+    assert result["type"] is FlowResultType.FORM
+    assert result["step_id"] == "map"
+    assert result["errors"] == {"base": "no_locations_found"}
+
+
+def test_location_select_label_without_supported_parameters() -> None:
+    """Test location select label with no supported parameters."""
+    location = OpenAQLocationFlowData(location_id=9999, title="Del Norte")
+
+    assert location.select_label == "Del Norte"
+
+
 @pytest.mark.parametrize(
     ("exception", "error"),
     [

tests/components/openaq/test_coordinator.py

@@ -1,11 +1,14 @@
 """Test OpenAQ data coordinator helpers."""
 
 from types import MappingProxyType, SimpleNamespace
+from unittest.mock import AsyncMock, patch
 
 import httpx
 
 from homeassistant.components.openaq.coordinator import (
+    HomeAssistantOpenAQTransport,
     OpenAQMeasurement,
+    async_create_openaq_client,
     create_openaq_client,
     get_openaq_value,
     normalize_latest_measurements,
@@ -14,10 +17,40 @@
     CONCENTRATION_MICROGRAMS_PER_CUBIC_METER,
     CONCENTRATION_MILLIGRAMS_PER_CUBIC_METER,
 )
+from homeassistant.core import HomeAssistant
 
 from .conftest import make_latest, make_sensor
 
 
+async def test_transport_sends_request_with_shared_httpx_client() -> None:
+    """Test the transport sends requests with the shared httpx client."""
+    response = httpx.Response(
+        200,
+        json={"results": []},
+        request=httpx.Request("GET", "https://api.openaq.org/v3/locations"),
+    )
+    httpx_client = AsyncMock(spec=httpx.AsyncClient)
+    httpx_client.request.return_value = response
+
+    transport = HomeAssistantOpenAQTransport(httpx_client)
+
+    assert (
+        await transport.send_request(
+            "GET",
+            "https://api.openaq.org/v3/locations",
+            params={"limit": 1},
+            headers={"X-API-Key": "api-key"},
+        )
+        is response
+    )
+    httpx_client.request.assert_awaited_once_with(
+        method="GET",
+        url="https://api.openaq.org/v3/locations",
+        params={"limit": 1},
+        headers={"X-API-Key": "api-key"},
+    )
+
+
 async def test_create_openaq_client_keeps_shared_httpx_client_open() -> None:
     """Test closing the OpenAQ client does not close the shared httpx client."""
     httpx_client = httpx.AsyncClient()
@@ -31,6 +64,25 @@ async def test_create_openaq_client_keeps_shared_httpx_client_open() -> None:
         await httpx_client.aclose()
 
 
+async def test_async_create_openaq_client_uses_shared_httpx_client(
+    hass: HomeAssistant,
+) -> None:
+    """Test creating an OpenAQ client from Home Assistant."""
+    httpx_client = httpx.AsyncClient()
+
+    try:
+        with patch(
+            "homeassistant.components.openaq.coordinator.get_async_client",
+            return_value=httpx_client,
+        ):
+            client = await async_create_openaq_client(hass, "api-key")
+
+        assert client.transport.client is httpx_client
+        await client.close()
+    finally:
+        await httpx_client.aclose()
+
+
 def test_get_openaq_value_dict() -> None:
     """Test getting OpenAQ values from dict data."""
     data = {"id": 123}
@@ -45,6 +97,7 @@ def test_normalize_latest_measurements_ignores_invalid_data() -> None:
         [
             make_latest("1", 8.5),
             make_latest("unknown", 12.1),
+            make_latest(999, 44.1),
             make_latest(2, True),
             make_latest(3, 33.2),
         ],

tests/components/openaq/test_sensor.py

@@ -20,7 +20,13 @@
 from homeassistant.util.unit_system import US_CUSTOMARY_SYSTEM
 
 from . import setup_integration
-from .conftest import LOCATION_ID, make_latest, make_response, make_sensor
+from .conftest import (
+    LOCATION_ID,
+    make_latest,
+    make_location,
+    make_response,
+    make_sensor,
+)
 
 from tests.common import MockConfigEntry, snapshot_platform
 
@@ -161,6 +167,30 @@ async def test_distance_from_home_sensor_uses_configured_unit_system(
     assert state.attributes["unit_of_measurement"] == UnitOfLength.MILES
 
 
+async def test_distance_from_home_sensor_unknown_without_coordinates(
+    hass: HomeAssistant,
+    entity_registry: er.EntityRegistry,
+    mock_openaq_client: AsyncMock,
+    mock_config_entry: MockConfigEntry,
+) -> None:
+    """Test distance from Home Assistant sensor without valid coordinates."""
+    mock_openaq_client.locations.get.return_value = make_response(
+        [make_location(coordinates=(True, -106.6))]
+    )
+    entity_registry.async_get_or_create(
+        "sensor",
+        "openaq",
+        f"{LOCATION_ID}_distance_from_home",
+        suggested_object_id="del_norte_distance_from_home_assistant",
+        disabled_by=None,
+    )
+
+    await setup_integration(hass, mock_config_entry)
+
+    assert (state := hass.states.get("sensor.del_norte_distance_from_home_assistant"))
+    assert state.state == STATE_UNKNOWN
+
+
 async def test_missing_latest_values_are_not_created(
     hass: HomeAssistant,
     entity_registry: er.EntityRegistry,