Skip to content

Commit 359be1f

Browse files
committed
Unblock python kernel update work
A few changes needed to unblock hex-inc/hex#39005 so it can land. * Approve `pypi/chardet` as a one-off for LGPL-2.1-or-later use, as it is present only in the root uv.lock as a development tool; it's not in any of the packages. * Allow two `filelock` security vulnerabilities that can't be patched in older python kernel versions. Note that these don't apply to newer python kernels and only ones that we have already stated that we do not maintain from a security perspective. GHSA-w853-jp5j-5j7f GHSA-qmgc-5h2g-mvrw * Replace `%2540` with `@` now that upstream fixed the bug.
1 parent e7a45e6 commit 359be1f

File tree

1 file changed

+26
-14
lines changed

1 file changed

+26
-14
lines changed

.github/workflows/dependency-review.yml

Lines changed: 26 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -78,21 +78,22 @@ jobs:
7878
# npm/canvas: Temporary addition due to ClearlyDefined error
7979
# (https://github.com/clearlydefined/curated-data/pull/32066)
8080
# npm/bignumber.js: ClearlyDefined error showing inaccurate license
81+
# pypi/chardet: LGPL-2.1-or-later -- only approving as a one-off
8182
allow-dependencies-licenses: >-
82-
pkg:npm/%2540lancedb/lancedb,
83-
pkg:npm/%2540lancedb/lancedb-darwin-arm64,
84-
pkg:npm/%2540lancedb/lancedb-darwin-x64,
85-
pkg:npm/%2540lancedb/lancedb-linux-arm64-gnu,
86-
pkg:npm/%2540lancedb/lancedb-linux-arm64-musl,
87-
pkg:npm/%2540lancedb/lancedb-linux-x64-gnu,
88-
pkg:npm/%2540lancedb/lancedb-linux-x64-musl,
89-
pkg:npm/%2540lancedb/lancedb-win32-arm64-msvc,
90-
pkg:npm/%2540lancedb/lancedb-win32-x64-msvc,
83+
pkg:npm/@lancedb/lancedb,
84+
pkg:npm/@lancedb/lancedb-darwin-arm64,
85+
pkg:npm/@lancedb/lancedb-darwin-x64,
86+
pkg:npm/@lancedb/lancedb-linux-arm64-gnu,
87+
pkg:npm/@lancedb/lancedb-linux-arm64-musl,
88+
pkg:npm/@lancedb/lancedb-linux-x64-gnu,
89+
pkg:npm/@lancedb/lancedb-linux-x64-musl,
90+
pkg:npm/@lancedb/lancedb-win32-arm64-msvc,
91+
pkg:npm/@lancedb/lancedb-win32-x64-msvc,
9192
pkg:npm/cookie-signature,
92-
pkg:npm/%2540ag-grid-enterprise/master-detail,
93-
pkg:npm/%2540pgsql/traverse,
94-
pkg:npm/%2540pgsql/types,
95-
pkg:npm/%2540pgsql/utils,
93+
pkg:npm/@ag-grid-enterprise/master-detail,
94+
pkg:npm/@pgsql/traverse,
95+
pkg:npm/@pgsql/types,
96+
pkg:npm/@pgsql/utils,
9697
pkg:npm/pgsql-parser,
9798
pkg:npm/pgsql-deparser,
9899
pkg:npm/pg-proto-parser,
@@ -101,6 +102,17 @@ jobs:
101102
pkg:pypi/charset-normalizer,
102103
pkg:maven/com.google.errorprone/error_prone_annotations,
103104
pkg:npm/canvas,
104-
pkg:npm/bignumber.js
105+
pkg:npm/bignumber.js,
106+
pkg:pypi/chardet
107+
108+
# Known vulnerabilities we're ok with ignoring.
109+
# These are generally because they are in an older python kernel
110+
# version that we aren't upgrading because it's EOL (and officially
111+
# unsupported by us).
112+
# filelock: https://github.com/advisories/GHSA-w853-jp5j-5j7f
113+
# filelock: https://github.com/advisories/GHSA-qmgc-5h2g-mvrw
114+
allow-ghsas: >-
115+
GHSA-w853-jp5j-5j7f,
116+
GHSA-qmgc-5h2g-mvrw
105117
106118
comment-summary-in-pr: on-failure

0 commit comments

Comments
 (0)