Skip to content

Comments

refactor(executor/device): deduplicate network initialization#2264

Open
cagatay-y wants to merge 1 commit intohermit-os:mainfrom
cagatay-y:refactor-executor-device
Open

refactor(executor/device): deduplicate network initialization#2264
cagatay-y wants to merge 1 commit intohermit-os:mainfrom
cagatay-y:refactor-executor-device

Conversation

@cagatay-y
Copy link
Contributor

Most of the network initialization code is the same whether DHCP is enabled or not. Merge the initialization function for the two cases to reflect that.

@mkroening mkroening self-assigned this Feb 19, 2026
Most of the network initialization code is the same whether DHCP is
enabled or not. Merge the initialization function for the two cases to
reflect that.
@cagatay-y cagatay-y force-pushed the refactor-executor-device branch from d9a8079 to 6ef84d7 Compare February 19, 2026 16:06
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Details
Benchmark Current: 6ef84d7 Previous: 04ab3e2 Performance Ratio
startup_benchmark Build Time 98.22 s 98.87 s 0.99
startup_benchmark File Size 0.86 MB 0.86 MB 1.00
Startup Time - 1 core 0.96 s (±0.03 s) 0.95 s (±0.03 s) 1.01
Startup Time - 2 cores 0.94 s (±0.03 s) 0.97 s (±0.03 s) 0.98
Startup Time - 4 cores 0.95 s (±0.03 s) 0.96 s (±0.03 s) 0.98
multithreaded_benchmark Build Time 97.71 s 101.80 s 0.96
multithreaded_benchmark File Size 0.96 MB 0.96 MB 1.00
Multithreaded Pi Efficiency - 2 Threads 91.53 % (±8.21 %) 91.38 % (±7.84 %) 1.00
Multithreaded Pi Efficiency - 4 Threads 45.21 % (±2.34 %) 44.41 % (±3.31 %) 1.02
Multithreaded Pi Efficiency - 8 Threads 25.82 % (±1.50 %) 25.72 % (±1.88 %) 1.00
micro_benchmarks Build Time 105.58 s 112.45 s 0.94
micro_benchmarks File Size 0.96 MB 0.96 MB 1.00
Scheduling time - 1 thread 68.75 ticks (±3.76 ticks) 71.54 ticks (±3.61 ticks) 0.96
Scheduling time - 2 threads 37.87 ticks (±4.78 ticks) 39.74 ticks (±4.96 ticks) 0.95
Micro - Time for syscall (getpid) 2.95 ticks (±0.32 ticks) 3.06 ticks (±0.30 ticks) 0.96
Memcpy speed - (built_in) block size 4096 69314.54 MByte/s (±49652.62 MByte/s) 64053.45 MByte/s (±45682.00 MByte/s) 1.08
Memcpy speed - (built_in) block size 1048576 29740.16 MByte/s (±24513.25 MByte/s) 29971.18 MByte/s (±24961.55 MByte/s) 0.99
Memcpy speed - (built_in) block size 16777216 28236.11 MByte/s (±23526.52 MByte/s) 25003.45 MByte/s (±21013.82 MByte/s) 1.13
Memset speed - (built_in) block size 4096 69794.42 MByte/s (±49924.97 MByte/s) 64316.32 MByte/s (±45851.10 MByte/s) 1.09
Memset speed - (built_in) block size 1048576 30490.40 MByte/s (±24959.86 MByte/s) 30752.34 MByte/s (±25389.93 MByte/s) 0.99
Memset speed - (built_in) block size 16777216 28947.00 MByte/s (±23914.14 MByte/s) 25753.82 MByte/s (±21487.22 MByte/s) 1.12
Memcpy speed - (rust) block size 4096 58554.51 MByte/s (±43235.40 MByte/s) 59798.08 MByte/s (±44107.11 MByte/s) 0.98
Memcpy speed - (rust) block size 1048576 29547.03 MByte/s (±24417.09 MByte/s) 29689.71 MByte/s (±24867.97 MByte/s) 1.00
Memcpy speed - (rust) block size 16777216 28383.34 MByte/s (±23657.16 MByte/s) 24799.81 MByte/s (±20847.11 MByte/s) 1.14
Memset speed - (rust) block size 4096 59408.88 MByte/s (±43786.32 MByte/s) 60738.74 MByte/s (±44654.61 MByte/s) 0.98
Memset speed - (rust) block size 1048576 30329.80 MByte/s (±24870.55 MByte/s) 30493.17 MByte/s (±25306.10 MByte/s) 0.99
Memset speed - (rust) block size 16777216 29107.43 MByte/s (±24055.15 MByte/s) 25549.21 MByte/s (±21318.77 MByte/s) 1.14
alloc_benchmarks Build Time 105.29 s 103.81 s 1.01
alloc_benchmarks File Size 0.93 MB 0.93 MB 1.00
Allocations - Allocation success 100.00 % 100.00 % 1
Allocations - Deallocation success 100.00 % 100.00 % 1
Allocations - Pre-fail Allocations 100.00 % 100.00 % 1
Allocations - Average Allocation time 8096.71 Ticks (±152.10 Ticks) 11018.15 Ticks (±189.29 Ticks) 0.73
Allocations - Average Allocation time (no fail) 8096.71 Ticks (±152.10 Ticks) 11018.15 Ticks (±189.29 Ticks) 0.73
Allocations - Average Deallocation time 1233.72 Ticks (±810.46 Ticks) 1054.71 Ticks (±332.39 Ticks) 1.17
mutex_benchmark Build Time 104.09 s 109.97 s 0.95
mutex_benchmark File Size 0.96 MB 0.96 MB 1.00
Mutex Stress Test Average Time per Iteration - 1 Threads 12.92 ns (±0.77 ns) 13.32 ns (±0.68 ns) 0.97
Mutex Stress Test Average Time per Iteration - 2 Threads 15.66 ns (±0.76 ns) 15.94 ns (±0.83 ns) 0.98

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants