DateTimeExtensions Not Working in Jar

[jbird-zwicker]

I am making use of the toDate() method in the DateTimeExtensions class, from the groovy-dateutil library.

In my project, when run via the IDE, this code works as expected:

Date d = LocalDate.now().toDate()

However, when the project is compiled to a Jar with gmavenplus, this line instead throws an exception:

Exception in thread "AWT-EventQueue-0" groovy.lang.MissingMethodException: No signature of method: java.time.LocalDate.toDate() is applicable for argument types: () values: []
Possible solutions: format(java.time.format.DateTimeFormatter), isCase(java.lang.Object), tap(groovy.lang.Closure), get(java.time.temporal.TemporalField), getAt(java.lang.String), putAt(java.lang.String, java.lang.Object)
	at org.codehaus.groovy.runtime.ScriptBytecodeAdapter.unwrap(ScriptBytecodeAdapter.java:72)
	at org.codehaus.groovy.vmplugin.v8.IndyGuardsFiltersAndSignatures.unwrap(IndyGuardsFiltersAndSignatures.java:163)
	at org.codehaus.groovy.vmplugin.v8.IndyInterface.fromCache(IndyInterface.java:321)

Below is my POM with sensitive information excluded:

pom.xml

``` 4.0.0

<groupId>ORG</groupId>
<artifactId>PROJECT</artifactId>
<version>1.0-SNAPSHOT</version>


<properties>
    <maven.compiler.source>1.8</maven.compiler.source>
    <maven.compiler.target>1.8</maven.compiler.target>
</properties>

<repositories>
    <!-- internal repository redacted -->
</repositories>

<dependencies>
    <!-- https://mvnrepository.com/artifact/com.github.lgooddatepicker/LGoodDatePicker -->
    <dependency>
        <groupId>com.github.lgooddatepicker</groupId>
        <artifactId>LGoodDatePicker</artifactId>
        <version>11.2.1</version>
    </dependency>
    <!-- https://mvnrepository.com/artifact/com.miglayout/miglayout-swing -->
    <dependency>
        <groupId>com.miglayout</groupId>
        <artifactId>miglayout-swing</artifactId>
        <version>5.3</version>
    </dependency>
    <!-- internal dependency redacted -->
    <!-- internal dependency redacted -->
    <!-- internal dependency redacted -->
    <!-- internal dependency redacted -->
    <!-- https://mvnrepository.com/artifact/org.junit.jupiter/junit-jupiter-api -->
    <dependency>
        <groupId>org.junit.jupiter</groupId>
        <artifactId>junit-jupiter-api</artifactId>
        <version>5.10.2</version>
        <scope>test</scope>
    </dependency>

    <dependency>
        <groupId>org.apache.groovy</groupId>
        <artifactId>groovy-dateutil</artifactId>
        <version>4.0.14</version>
        <type>pom</type>
    </dependency>
    <dependency>
        <groupId>org.apache.groovy</groupId>
        <artifactId>groovy-all</artifactId>
        <version>4.0.14</version>
        <type>pom</type>
    </dependency>
    <!-- https://mvnrepository.com/artifact/org.spockframework/spock-core -->
    <dependency>
        <groupId>org.spockframework</groupId>
        <artifactId>spock-core</artifactId>
        <version>2.4-M5-groovy-4.0</version>
        <scope>test</scope>
    </dependency>
</dependencies>


<build>
    <plugins>
        <plugin>
            <groupId>org.codehaus.gmavenplus</groupId>
            <artifactId>gmavenplus-plugin</artifactId>
            <version>4.2.1</version>
            <executions>
                <execution>
                    <goals>
                        <goal>addSources</goal>
                        <goal>addTestSources</goal>
                        <goal>generateStubs</goal>
                        <goal>compile</goal>
                        <goal>generateTestStubs</goal>
                        <goal>compileTests</goal>
                        <goal>removeStubs</goal>
                        <goal>removeTestStubs</goal>
                    </goals>
                </execution>
            </executions>
        </plugin>
        <plugin>
            <artifactId>maven-assembly-plugin</artifactId>
            <configuration>
                <finalName>PROJECT</finalName>
                <appendAssemblyId>false</appendAssemblyId>
                <archive>
                    <manifest>
                        <mainClass>ORG.PROJECT.Main</mainClass>
                    </manifest>
                </archive>
                <descriptorRefs>
                    <descriptorRef>jar-with-dependencies</descriptorRef>
                </descriptorRefs>
            </configuration>
        </plugin>
        <plugin>
            <artifactId>maven-compiler-plugin</artifactId>
            <configuration>
                <source>1.8</source>
                <target>1.8</target>
            </configuration>
        </plugin>
    </plugins>
</build>

```

[keeganwitt]

I'd try running mvn dependency:tree to make sure the version of groovy and groovy-dateutil that's brought in as jars matches the ones that are pom types you've declared.

[jbird-zwicker]

@keeganwitt Thanks for your reply -- I can confirm the results of mvn dependency:tree match the versions specified in my pom file.

[jbird-zwicker]

Adding on to this -- I am seeing the same problem with the NioExtensions class when attempting to use the deleteDir() method.

[jbird-zwicker]

I believe this StackOverflow post is relevant:

https://stackoverflow.com/questions/65568716/how-do-i-include-groovy-extension-methods-in-jar

I'm not versed enough on Maven to know how I would accomplish this, but it appears the solution may be to have a step that inserts the ExtensionModule into the META-INF/services directory of the artifact.

[keeganwitt]

Which runtime Java version are you both using?

[jbird-zwicker]

@keeganwitt I am using Java 8.

[keeganwitt]

Problems like this are why I prefer the shade plugin for this instead of the assembly plugin. This fixed the issue for me locally.

<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-shade-plugin</artifactId>
    <version>3.5.0</version>
    <executions>
        <execution>
            <phase>package</phase>
            <goals>
                <goal>shade</goal>
            </goals>
            <configuration>
                <transformers>
                    <transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
                        <mainClass>ORG.PROJECT.Main</mainClass>
                    </transformer>
                    <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer">
                        <resource>META-INF/groovy/org.codehaus.groovy.runtime.ExtensionModule</resource>
                    </transformer>
                </transformers>
            </configuration>
        </execution>
    </executions>
</plugin>

[keeganwitt]

If you really want to use the assembly plugin (which I recommend against), here's what worked for me locally:

<plugin>
    <artifactId>maven-assembly-plugin</artifactId>
    <configuration>
        <finalName>PROJECT</finalName>
        <appendAssemblyId>false</appendAssemblyId>
        <archive>
            <manifest>
                <mainClass>ORG.PROJECT.Main</mainClass>
            </manifest>
        </archive>
        <descriptors>
            <descriptor>src/assembly/uber.xml</descriptor>
        </descriptors>
    </configuration>
    <executions>
        <execution>
            <id>make-assembly</id>
            <phase>package</phase>
            <goals>
                <goal>single</goal>
            </goals>
        </execution>
    </executions>
</plugin>

<!-- uber.xml -->
<assembly xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.3"
          xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.3 http://maven.apache.org/xsd/assembly-1.1.3.xsd">
    <id>uber</id>
    <formats>
        <format>jar</format>
    </formats>
    <includeBaseDirectory>false</includeBaseDirectory>
    <dependencySets>
        <dependencySet>
            <outputDirectory>/</outputDirectory>
            <useProjectArtifact>true</useProjectArtifact>
            <unpack>true</unpack>
            <scope>runtime</scope>
        </dependencySet>
    </dependencySets>
    <fileSets>
        <fileSet>
            <directory>${project.build.outputDirectory}</directory>
            <outputDirectory>/</outputDirectory>
            <includes>
                <include>**/*</include>
            </includes>
        </fileSet>
    </fileSets>
    <containerDescriptorHandlers>
        <containerDescriptorHandler>
            <handlerName>metaInf-services</handlerName>
        </containerDescriptorHandler>
        <containerDescriptorHandler>
            <handlerName>file-aggregator</handlerName>
            <configuration>
                <filePattern>META-INF/groovy/org.codehaus.groovy.runtime.ExtensionModule</filePattern>
                <outputPath>META-INF/groovy/org.codehaus.groovy.runtime.ExtensionModule</outputPath>
            </configuration>
        </containerDescriptorHandler>
    </containerDescriptorHandlers>
</assembly>

[keeganwitt]

What can happen if you're not combining service files, is the file from one dependency can overwrite another, causing service entries to be missing at runtime. I'm not sure the order is deterministic.

[jbird-zwicker]

@keeganwitt thank you for the suggestion -- I have no affinity for the assembly plugin in particular; it just happens to be what I tend to use. I'll give the shade plugin a go and see if this works.

[jbird-zwicker]

I'm sorry to say it looks like the Shade plugin by itself wasn't sufficient to resolve the problem for me. Perhaps I've not implemented it correctly?

I commented out the Assembly plugin section and added this in its place:

            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-shade-plugin</artifactId>
                <version>3.5.0</version>
                <executions>
                    <execution>
                        <phase>package</phase>
                        <goals>
                            <goal>shade</goal>
                        </goals>
                        <configuration>
                            <transformers>
                                <transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
                                    <mainClass>ORG.PROJECT.Main</mainClass>
                                </transformer>
                                <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer">
                                    <resource>META-INF/groovy/org.codehaus.groovy.runtime.ExtensionModule</resource>
                                </transformer>
                            </transformers>
                        </configuration>
                    </execution>
                </executions>
            </plugin>

I ran mvn clean compile package shade:shade to create the artifact, and tried all 3 versions generated (original-<jarname>.jar,<jarname>.jar, and <jarname>-shaded.jar) with the same result.

Below is a screenshot of the META-INF section of the Jar as viewed through jd-gui 1.6.6.

[keeganwitt]

Here's the test I was using: https://github.com/keeganwitt/gmavenplus-jar-extensions-test. I'm not sure what's different about your setup?

[jbird-zwicker]

I just downloaded your sample project, and that worked perfectly. I modified my POM file to mirror yours (copying the section and changing the main class to be the real one) and added the src/assembly/uber.xml file exactly as yours is...and it's still failing.

Next I did a diff between your sample pom and mine. I noted that I had the various Groovy dependencies set to pom instead of jar, so I changed mine to match yours. I also added the groovy-datetime dependency and swapped groovy-all for plain groovy. Unfortunately the same result there too.

But I finally thought to perform one more test -- the project I'm encountering this problem with includes 2 Groovy-based artifacts hosted on our local Maven repository and created with the same assembly settings as what I originally posted. I added these two dependencies to your sample project, and the extensions started failing. The same happened with each individually.

I can't remove these dependencies from my original project without breaking core functionality, unfortunately. But the solution must lie with these two. I'll have to test with changing their maven configuration to resolve this.

[keeganwitt]

I wonder if the META_INF/groovy in those two internal jars is interfering? What content do you see there?

[jbird-zwicker]

The META-INF has a lot of data from just one of the dependencies, HandyGroovyDoodads. I made made some changes to the project for testing:

• added src/assembly/uber.xml
• updated the assembly section to mirror your test project
• deployed 1.3.1-SNAPSHOT
  I then updated the dependency in the test project to use this new version, and it still failed.

The META-INF does differ between the updated and original dependency versions, though not enough to let the ExtensionModule work. I'm uploading them here if you want to take a look. Maybe you can see something I'm missing.

with-dep.zip
with-dep-updated.zip

EDIT: I meant to say, perhaps there is something in the maven-deploy plugin configuration I could be changing. I'm pretty green when it comes to Maven so I'm not sure what I could be doing differently.