Skip to content

Commit 150d240

Browse files
committed
Resubmit to CRAN: fix MCMC acronym, add reference, replace dontrun with donttest
1 parent 68be151 commit 150d240

8 files changed

Lines changed: 58 additions & 35 deletions

File tree

CRAN-SUBMISSION

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
Version: 0.1.0
2+
Date: 2026-04-16 12:04:25 UTC
3+
SHA: 68be151dc236093159c9cf8849357017fb4a7021

DESCRIPTION

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,17 @@ Description: Provides comprehensive methods to calculate posterior probabilities
2323
External designs incorporate historical data through power priors
2424
using exact conjugate representations (Normal-Inverse-Chi-squared for single
2525
continuous, Normal-Inverse-Wishart for two continuous, and Dirichlet for
26-
binary endpoints), enabling closed-form posterior computation without MCMC
27-
sampling. This approach significantly reduces computational burden while
28-
preserving complete Bayesian rigor. The package also provides grid-search
29-
functions to find optimal Go and NoGo thresholds that satisfy user-specified
30-
operating characteristic criteria for all supported endpoint types and
31-
study designs. S3 print() and plot() methods are provided for all decision
32-
probability classes, enabling formatted display and visualisation of
33-
Go/NoGo/Gray operating characteristics across treatment scenarios.
26+
binary endpoints), enabling closed-form posterior computation without Markov
27+
chain Monte Carlo (MCMC) sampling. This approach significantly reduces
28+
computational burden while preserving complete Bayesian rigor. The package
29+
also provides grid-search functions to find optimal Go and NoGo thresholds
30+
that satisfy user-specified operating characteristic criteria for all
31+
supported endpoint types and study designs. S3 print() and plot() methods
32+
are provided for all decision probability classes, enabling formatted display
33+
and visualisation of Go/NoGo/Gray operating characteristics across treatment
34+
scenarios.
35+
See Kang, Yamaguchi, and Han (2026) <doi:10.1080/10543406.2026.2655410>
36+
for the methodological framework.
3437
License: GPL (>= 2)
3538
Encoding: UTF-8
3639
Language: en-US

NEWS.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
# BayesianQDM 0.1.0
22

3+
## Resubmission
4+
5+
* Expanded the MCMC acronym to "Markov chain Monte Carlo (MCMC)" in DESCRIPTION.
6+
* Added a reference to Kang, Yamaguchi, and Han (2026) in DESCRIPTION.
7+
* Replaced `\dontrun{}` with `\donttest{}` in examples for `getgamma2bin()` and
8+
`getgamma2cont()`.
9+
310
## Initial Release
411

512
Initial release providing a comprehensive Bayesian quantitative decision-making

R/getgamma2bin.R

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@
217217
#' # Example 1: Controlled design, posterior probability
218218
#' # gamma_go : smallest gamma_go s.t. max_{gamma_nogo} Pr(Go) < 0.05 under Null
219219
#' # gamma_nogo: smallest gamma_nogo s.t. max_{gamma_go} Pr(NoGo) < 0.20 under Alt
220-
#' \dontrun{
220+
#' \donttest{
221221
#' getgamma2bin(
222222
#' prob = 'posterior', design = 'controlled',
223223
#' GoRegions = 1L, NoGoRegions = 9L,
@@ -244,7 +244,7 @@
244244
#' }
245245
#'
246246
#' # Example 2: Uncontrolled design, posterior probability
247-
#' \dontrun{
247+
#' \donttest{
248248
#' getgamma2bin(
249249
#' prob = 'posterior', design = 'uncontrolled',
250250
#' GoRegions = 1L, NoGoRegions = 9L,
@@ -271,7 +271,7 @@
271271
#' }
272272
#'
273273
#' # Example 3: External design, posterior probability
274-
#' \dontrun{
274+
#' \donttest{
275275
#' getgamma2bin(
276276
#' prob = 'posterior', design = 'external',
277277
#' GoRegions = 1L, NoGoRegions = 9L,
@@ -298,7 +298,7 @@
298298
#' }
299299
#'
300300
#' # Example 4: Controlled design, predictive probability
301-
#' \dontrun{
301+
#' \donttest{
302302
#' getgamma2bin(
303303
#' prob = 'predictive', design = 'controlled',
304304
#' GoRegions = 1L, NoGoRegions = 4L,
@@ -325,7 +325,7 @@
325325
#' }
326326
#'
327327
#' # Example 5: Uncontrolled design, predictive probability
328-
#' \dontrun{
328+
#' \donttest{
329329
#' getgamma2bin(
330330
#' prob = 'predictive', design = 'uncontrolled',
331331
#' GoRegions = 1L, NoGoRegions = 4L,
@@ -352,7 +352,7 @@
352352
#' }
353353
#'
354354
#' # Example 6: External design, predictive probability
355-
#' \dontrun{
355+
#' \donttest{
356356
#' getgamma2bin(
357357
#' prob = 'predictive', design = 'external',
358358
#' GoRegions = 1L, NoGoRegions = 4L,

R/getgamma2cont.R

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@
238238
#' # Example 1: Controlled design, posterior probability, vague prior
239239
#' # gamma_go : smallest gamma_go s.t. max_{gamma_nogo} Pr(Go) < 0.05 under Null
240240
#' # gamma_nogo: smallest gamma_nogo s.t. max_{gamma_go} Pr(NoGo) < 0.20 under Alt
241-
#' \dontrun{
241+
#' \donttest{
242242
#' Sigma_null <- matrix(c(6400.0, 15.0, 15.0, 36.0), 2, 2)
243243
#' Sigma_alt <- matrix(c(6400.0, 15.0, 15.0, 36.0), 2, 2)
244244
#' getgamma2cont(
@@ -268,7 +268,7 @@
268268
#' }
269269
#'
270270
#' # Example 2: Uncontrolled design, posterior probability, vague prior
271-
#' \dontrun{
271+
#' \donttest{
272272
#' Sigma_null <- matrix(c(6400.0, 15.0, 15.0, 36.0), 2, 2)
273273
#' Sigma_alt <- matrix(c(6400.0, 15.0, 15.0, 36.0), 2, 2)
274274
#' getgamma2cont(
@@ -298,7 +298,7 @@
298298
#' }
299299
#'
300300
#' # Example 3: External design (control only), posterior probability, NIW prior
301-
#' \dontrun{
301+
#' \donttest{
302302
#' Sigma <- matrix(c(6400.0, 15.0, 15.0, 36.0), 2, 2)
303303
#' Lambda <- matrix(c(6400.0, 15.0, 15.0, 36.0), 2, 2)
304304
#' se_c <- matrix(c(6400.0, 15.0, 15.0, 36.0), 2, 2)
@@ -329,7 +329,7 @@
329329
#' }
330330
#'
331331
#' # Example 4: Controlled design, predictive probability, vague prior
332-
#' \dontrun{
332+
#' \donttest{
333333
#' Sigma_null <- matrix(c(6400.0, 15.0, 15.0, 36.0), 2, 2)
334334
#' Sigma_alt <- matrix(c(6400.0, 15.0, 15.0, 36.0), 2, 2)
335335
#' getgamma2cont(
@@ -359,7 +359,7 @@
359359
#' }
360360
#'
361361
#' # Example 5: Uncontrolled design, predictive probability, vague prior
362-
#' \dontrun{
362+
#' \donttest{
363363
#' Sigma_null <- matrix(c(6400.0, 15.0, 15.0, 36.0), 2, 2)
364364
#' Sigma_alt <- matrix(c(6400.0, 15.0, 15.0, 36.0), 2, 2)
365365
#' getgamma2cont(
@@ -389,7 +389,7 @@
389389
#' }
390390
#'
391391
#' # Example 6: External design (control only), predictive probability, NIW prior
392-
#' \dontrun{
392+
#' \donttest{
393393
#' Sigma <- matrix(c(6400.0, 15.0, 15.0, 36.0), 2, 2)
394394
#' Lambda <- matrix(c(6400.0, 15.0, 15.0, 36.0), 2, 2)
395395
#' se_c <- matrix(c(6400.0, 15.0, 15.0, 36.0), 2, 2)

cran-comments.md

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,12 @@
1010

1111
## R CMD check results
1212

13-
0 errors | 0 warnings | 0 notes
13+
0 errors | 0 warnings | 1 note
14+
15+
* checking for future file timestamps ... NOTE
16+
unable to verify current time
17+
This is a transient network issue in the check environment and is not
18+
related to the package itself.
1419

1520
## Package Summary
1621

@@ -39,6 +44,11 @@ operating characteristics across treatment scenarios.
3944
speed and precision; default values are set conservatively for CRAN checks
4045
* All examples in the documentation are designed to complete within a few seconds
4146

42-
## Previous CRAN Submissions
47+
## Resubmission
48+
49+
This is a resubmission following reviewer feedback. The following changes were made:
4350

44-
This is the initial submission to CRAN.
51+
* Expanded the MCMC acronym to "Markov chain Monte Carlo (MCMC)" in DESCRIPTION.
52+
* Added a reference to Kang, Yamaguchi, and Han (2026) in DESCRIPTION.
53+
* Replaced `\dontrun{}` with `\donttest{}` in examples for `getgamma2bin()` and
54+
`getgamma2cont()`.

man/getgamma2bin.Rd

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/getgamma2cont.Rd

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)