Skip to content

Commit 2664e20

Browse files
committed
test: update and fix unit test error
1 parent 80e07fd commit 2664e20

File tree

2 files changed

+22
-5
lines changed

2 files changed

+22
-5
lines changed

gcli.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -219,6 +219,7 @@ func (g *GOptions) SetDisable() {
219219
func (g *GOptions) bindingFlags(fs *Flags) {
220220
fs.BoolOpt(&g.showHelp, "help", "h", false, "Display the help information")
221221

222+
// disabled
222223
if g.Disable {
223224
return
224225
}

gcli_test.go

Lines changed: 21 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,16 +27,24 @@ func TestVerbose(t *testing.T) {
2727
gcli.SetQuietMode()
2828
is.Eq(gcli.VerbQuiet, gcli.Verbose())
2929

30-
gcli.SetVerbose(gcli.VerbInfo)
31-
is.Eq(gcli.VerbInfo, gcli.Verbose())
32-
is.Eq("info", gcli.Verbose().Name())
33-
is.Eq("INFO", gcli.Verbose().Upper())
30+
info := gcli.VerbInfo
31+
gcli.SetVerbose(info)
32+
is.Eq(info, gcli.Verbose())
33+
is.Eq(3, info.Int())
34+
is.Eq("info", info.Name())
35+
is.Eq("INFO", info.Upper())
3436

3537
gcli.SetVerbose(old)
3638
is.Eq(gcli.VerbError, gcli.Verbose())
39+
}
40+
41+
func TestVerbLevel(t *testing.T) {
42+
is := assert.New(t)
3743

3844
verb := gcli.VerbLevel(23)
3945
is.Eq("unknown", verb.Name())
46+
is.Eq(23, verb.Int())
47+
4048
err := verb.Set("2")
4149
is.NoErr(err)
4250
is.Eq(gcli.VerbWarn, verb)
@@ -56,7 +64,10 @@ func TestVerbose(t *testing.T) {
5664
func TestStrictMode(t *testing.T) {
5765
is := assert.New(t)
5866

59-
is.True(gcli.StrictMode())
67+
old := gcli.StrictMode()
68+
defer func() {
69+
gcli.SetStrictMode(old)
70+
}()
6071

6172
gcli.SetStrictMode(false)
6273
is.False(gcli.StrictMode())
@@ -121,5 +132,10 @@ func TestSetStrictMode(t *testing.T) {
121132
app.Run([]string{"test", "-ob"})
122133
assert.True(t, opts.ok)
123134
assert.True(t, opts.bl)
135+
}
124136

137+
func TestString(t *testing.T) {
138+
s := gcli.String("ab,cd")
139+
assert.Eq(t, "ab,cd", s.String())
140+
assert.Eq(t, []string{"ab", "cd"}, s.Split(","))
125141
}

0 commit comments

Comments
 (0)