Merge pull request #202 from vvidic/login-param

Fix broken command line options

Author: pkern

login/config.c

@@ -311,7 +311,13 @@ status_t glome_login_assign_config_option(glome_login_config_t *config,
                                           const char *section, const char *key,
                                           const char *val) {
   if (section == NULL) {
-    return status_createf("ERROR: section name not set");
+    return status_createf("ERROR: config section not set");
+  }
+  if (key == NULL) {
+    return status_createf("ERROR: config key not set");
+  }
+  if (val == NULL) {
+    return status_createf("ERROR: config value not set");
   }
 
   if (strcmp(section, "service") == 0) {
@@ -320,7 +326,7 @@ status_t glome_login_assign_config_option(glome_login_config_t *config,
     return assign_default_option(config, key, val);
   }
 
-  return status_createf("ERROR: section name not recognized: %s", section);
+  return status_createf("ERROR: config section not recognized: %s", section);
 }
 
 status_t glome_login_parse_config_file(glome_login_config_t *config) {

login/ui.c

@@ -173,7 +173,7 @@ int parse_args(glome_login_config_t* config, int argc, char* argv[]) {
             glome_login_assign_config_option(config, "service", "key", optarg);
         break;
       case 'l':
-        status = glome_login_assign_config_option(config, "service",
+        status = glome_login_assign_config_option(config, "default",
                                                   "login-path", optarg);
         break;
       case 'm':
@@ -186,19 +186,19 @@ int parse_args(glome_login_config_t* config, int argc, char* argv[]) {
         break;
       case 's':
         status = glome_login_assign_config_option(config, "default",
-                                                  "disable-syslog", optarg);
+                                                  "disable-syslog", "true");
         break;
       case 't':
         status = glome_login_assign_config_option(config, "default", "timeout",
                                                   optarg);
         break;
       case 'v':
         status = glome_login_assign_config_option(config, "default", "verbose",
-                                                  optarg);
+                                                  "true");
         break;
       case 'I':
         status = glome_login_assign_config_option(config, "default",
-                                                  "print-secrets", optarg);
+                                                  "print-secrets", "true");
         break;
       case 'K':
         status = glome_login_assign_config_option(config, "default",