Commit c607816
authored
fix: exports["."].require pointing at .js instead of the real .cjs build output (#1499)
Found while upgrading gasket packages in a downstream app: @gasket/plugin-docs
and @gasket/plugin-intl's package.json exports maps declare
`"require": "./cjs/index.js"`, but gasket-cjs only ever emits
`./cjs/index.cjs` — the .js path never exists, so any CJS consumer
(require('@gasket/plugin-docs')) gets MODULE_NOT_FOUND unconditionally.
Swept every package in the monorepo for the same pattern (any exports
condition ending in .js under a cjs/ path) and found 3 more instances of the
identical copy/paste mistake:
- @gasket/plugin-docs-graphs: both `require` and `default` wrong
- @gasket/plugin-happyfeet: `require` wrong (its `default` was already
correct)
- @gasket/plugin-swagger: both the main export and the "./prompts" subpath
export wrong
All fixed to point at the .cjs file that actually exists. Same root-cause
family as the gasket-plugin-switchboard fix in #2272.
Co-authored-by: ssmith2-godaddy <>1 parent 16cbc1d commit c607816
7 files changed
Lines changed: 22 additions & 8 deletions
File tree
- .changeset
- packages
- gasket-plugin-docs-graphs
- gasket-plugin-docs
- gasket-plugin-happyfeet
- gasket-plugin-intl
- gasket-plugin-swagger
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
16 | | - | |
| 15 | + | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
| 18 | + | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
17 | | - | |
| 16 | + | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| |||
0 commit comments