feat: add inline ClassFieldAccess phpdoc in property hook generation

Agent-Logs-Url: https://github.com/goaop/framework/sessions/0dfed7bf-8709-43b7-8d60-aefe9f468557

Co-authored-by: lisachenko <640114+lisachenko@users.noreply.github.com>

Author: Copilot

src/Proxy/Part/InterceptedPropertyGenerator.php

@@ -18,6 +18,7 @@
 use Go\Proxy\Generator\PropertyNodeProvider;
 use Go\Proxy\Generator\TypeGenerator;
 use InvalidArgumentException;
+use PhpParser\Comment\Doc;
 use PhpParser\Node\Arg;
 use PhpParser\Node\Expr\ArrayDimFetch;
 use PhpParser\Node\Expr\Assign;
@@ -146,15 +147,17 @@ public function getNode(): PropertyNode
     private function createGetHook(bool $returnsByReference): PropertyHook
     {
         $propertyName = $this->property->getName();
+        $fieldAccessExpression = new Expression(new Assign(
+            new Variable('fieldAccess'),
+            new ArrayDimFetch(
+                new StaticPropertyFetch(new Name('self'), JoinPointPropertyGenerator::NAME),
+                new String_('prop:' . $propertyName)
+            )
+        ));
+        $fieldAccessExpression->setDocComment(new Doc('/** @var ClassFieldAccess<self> $fieldAccess */'));
 
         return new PropertyHook('get', [
-            new Expression(new Assign(
-                new Variable('fieldAccess'),
-                new ArrayDimFetch(
-                    new StaticPropertyFetch(new Name('self'), JoinPointPropertyGenerator::NAME),
-                    new String_('prop:' . $propertyName)
-                )
-            )),
+            $fieldAccessExpression,
             new Expression(new AssignRef(
                 new Variable('value'),
                 new MethodCall(new Variable('fieldAccess'), '__invoke', [
@@ -181,15 +184,17 @@ private function createGetHook(bool $returnsByReference): PropertyHook
     private function createSetHook(): PropertyHook
     {
         $propertyName = $this->property->getName();
+        $fieldAccessExpression = new Expression(new Assign(
+            new Variable('fieldAccess'),
+            new ArrayDimFetch(
+                new StaticPropertyFetch(new Name('self'), JoinPointPropertyGenerator::NAME),
+                new String_('prop:' . $propertyName)
+            )
+        ));
+        $fieldAccessExpression->setDocComment(new Doc('/** @var ClassFieldAccess<self> $fieldAccess */'));
 
         return new PropertyHook('set', [
-            new Expression(new Assign(
-                new Variable('fieldAccess'),
-                new ArrayDimFetch(
-                    new StaticPropertyFetch(new Name('self'), JoinPointPropertyGenerator::NAME),
-                    new String_('prop:' . $propertyName)
-                )
-            )),
+            $fieldAccessExpression,
             new Expression(new Assign(
                 new PropertyFetch(new Variable('this'), $propertyName),
                 new MethodCall(new Variable('fieldAccess'), '__invoke', [

tests/Proxy/ClassProxyGeneratorTest.php

@@ -97,10 +97,11 @@ public function testGenerateWithPropertyInterception(): void
         );
         $this->assertStringContainsString("self::\$__joinPoints['prop:public'];", $proxyFileContent);
         $this->assertStringContainsString(
-            "set {\n            \$fieldAccess = self::\$__joinPoints['prop:public'];",
+            "/** @var ClassFieldAccess<self> \$fieldAccess */",
             $proxyFileContent,
             'Proxy with property advices must route writes through join points in property hooks'
         );
+        $this->assertStringContainsString("set {\n            /** @var ClassFieldAccess<self> \$fieldAccess */", $proxyFileContent);
         $this->assertStringNotContainsString('PropertyInterceptionTrait', $proxyFileContent);
         $this->assertStringNotContainsString('__properties', $proxyFileContent);
     }