Atomic stack merge incorrectly reports missing CODEOWNER approval #501
yoperiquoi
started this conversation in
Feedback
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Summary
gh stack mergerejects an otherwise mergeable stack with a missing CODEOWNER review error, although every pull request is approved on its current head commit by a reviewer who GitHub recognizes as a member of a required CODEOWNERS team.Stack
mergeStateStatus: CLEANreviewDecision: APPROVEDBranch protection
The stack base branch requires:
The repository CODEOWNERS rules have a default owner group and a more specific owner group for the changed service directory.
Verification performed
For each pull request:
The approval reviewers differ between layers, but every layer has its own valid and current CODEOWNER approval.
Failure
Running the atomic merge produces:
The reported owners correspond to the repository CODEOWNERS rules, but valid approvals from members of those teams are already present.
Environment
Expected behavior
The stack should merge atomically because every layer satisfies the base branch review and CODEOWNER requirements, or the error should identify the specific PR/review that the asynchronous stack merge API considers invalid.
Actual behavior
Atomic stack merge rejects the entire stack with a generic missing CODEOWNER approval message, while the normal PR API reports every PR as clean and approved.
All reactions