Update review cancellation instructions and screenshot - #45812
Conversation
Updated the instructions for canceling a pending review to reflect the correct button actions.
|
👋 Hi there! It looks like you've modified some files that we can't accept as contributions:
You'll need to raise a new PR that doesn't include those files, before we can review. The complete list of files we can't accept are:
We also can't accept contributions to files in the content directory with frontmatter |
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
|
👋 Hi there! It looks like you've modified some files that we can't accept as contributions:
You'll need to raise a new PR that doesn't include those files, before we can review. The complete list of files we can't accept are:
We also can't accept contributions to files in the content directory with frontmatter |
subatoi
left a comment
There was a problem hiding this comment.
Hi @ashis-baral—I'm happy to accept this but we have stringent requirements on image quality. I think we can just delete this image, so if you'd like to go ahead and do that in your PR, I'll accept it and we can merge it. Thank you!
|
HI @subatoi I just want to double check — I captured this screenshot specifically following the technical requirements in the Creating screenshots guide, and it checks out against all of them: Format: PNG ✅ |
There was a problem hiding this comment.
@ashis-baral So you did — it's so rare that contributors actually follow those guidelines correctly that I have to admit I didn't check, so I do apologise about that. I'll go ahead and get this merged 🙇
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
|
@subatoi Ha, no worries at all — glad it checked out! Thanks for taking another look and for merging it. I really appreciate it. 👍 |
|
No problem—thank you for your help, again! |
Why:
fix: #45811
What's being changed (if available, include any code snippets, screenshots, or gifs):
Updated the instructions in the "Starting a review" section of the pull request review documentation to reflect the current GitHub UI.
The previous instructions directed users to click Review changes, then Abandon review. In the current UI, users need to click Submit review, then click Discard review to cancel a pending review.
Also replaced the outdated screenshot with an updated screenshot showing the current Submit review → Discard review workflow.
Check off the following: