Skip to content

Commit d8c66e1

Browse files
committed
fix: use PATCH instead of PUT for updates in HL API v2
1 parent a6f7c5c commit d8c66e1

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

glpi_utils/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
from .logger import EmptyHandler, SensitiveFilter
4242
from .version import GLPIVersion
4343

44-
__version__ = "1.4.0"
44+
__version__ = "1.4.1"
4545

4646
__all__ = [
4747
# Clients

glpi_utils/oauth.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -552,11 +552,11 @@ def update_item(self, itemtype: str, input_data: Any, **kwargs: Any) -> list:
552552
item_id = input_data["id"]
553553
body = {k: v for k, v in input_data.items() if k != "id"}
554554
body.update(kwargs)
555-
return self._request("PUT", f"{_hl_route(itemtype)}/{item_id}", json=body)
555+
return self._request("PATCH", f"{_hl_route(itemtype)}/{item_id}", json=body)
556556
# Fallback for list input (bulk) - not natively supported in HL API
557557
payload: dict = {"input": input_data}
558558
payload.update(kwargs)
559-
return self._request("PUT", _hl_route(itemtype), json=payload)
559+
return self._request("PATCH", _hl_route(itemtype), json=payload)
560560

561561
def delete_item(
562562
self,
@@ -886,10 +886,10 @@ async def update_item(self, itemtype: str, input_data: Any, **kwargs: Any) -> li
886886
item_id = input_data["id"]
887887
body = {k: v for k, v in input_data.items() if k != "id"}
888888
body.update(kwargs)
889-
return await self._request("PUT", f"{_hl_route(itemtype)}/{item_id}", json=body)
889+
return await self._request("PATCH", f"{_hl_route(itemtype)}/{item_id}", json=body)
890890
payload: dict = {"input": input_data}
891891
payload.update(kwargs)
892-
return await self._request("PUT", _hl_route(itemtype), json=payload)
892+
return await self._request("PATCH", _hl_route(itemtype), json=payload)
893893

894894
async def delete_item(self, itemtype: str, input_data: Any, force_purge: bool = False, history: bool = True) -> list:
895895
if isinstance(input_data, dict) and "id" in input_data:

setup.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[metadata]
22
name = glpi-utils
3-
version = 1.4.0
3+
version = 1.4.1
44
author = Giovanny Rodriguez
55
author_email = giovanny@imagunet.com
66
description = Python library for working with the GLPI REST API (9.1+, 10.x, 11.x)

0 commit comments

Comments
 (0)