Implement nelson stacks list -u (#30)

* Implement `nelson stacks list -u`

The arg for this was implemented but wasn't actually plumbed through to the API call.

This PR plumbs it through, and also tidies a few minor things up. I've tested it against a Nelson cluster.

* build query string using url.Values instead

Author: slai

src/github.com/getnelson/nelson/main.go

@@ -20,15 +20,16 @@ import (
 	"crypto/sha256"
 	"encoding/base64"
 	"fmt"
-	"github.com/parnurzeal/gorequest"
-	"gopkg.in/urfave/cli.v1"
 	"io/ioutil"
 	"log"
 	"os"
 	"regexp"
 	"strconv"
 	"strings"
 	"time"
+
+	"github.com/parnurzeal/gorequest"
+	"gopkg.in/urfave/cli.v1"
 )
 
 var globalTimeoutSeconds int
@@ -56,6 +57,7 @@ func main() {
 	var selectedNamespace string
 	var selectedLoadbalancer string
 	var selectedStatus string
+	var selectedUnit string
 	var selectedUnitPrefix string
 	var selectedVersion string
 	var selectedPort int64
@@ -645,8 +647,8 @@ func main() {
 						cli.StringFlag{
 							Name:        "unit, u",
 							Value:       "",
-							Usage:       "Only list stacks that match a specified unit prefix",
-							Destination: &selectedUnitPrefix,
+							Usage:       "Only list stacks that match the specified unit",
+							Destination: &selectedUnit,
 						},
 						cli.StringFlag{
 							Name:        "datacenters, d",
@@ -688,7 +690,7 @@ func main() {
 
 						pi.Start()
 						cfg := LoadDefaultConfigOrExit(http)
-						r, e := ListStacks(selectedDatacenter, selectedNamespace, selectedStatus, http, cfg)
+						r, e := ListStacks(selectedDatacenter, selectedNamespace, selectedStatus, selectedUnit, http, cfg)
 						pi.Stop()
 						if e != nil {
 							PrintTerminalErrors(e)

src/github.com/getnelson/nelson/stack.go

@@ -20,9 +20,11 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
+	"net/url"
+	"strconv"
+
 	"github.com/fatih/color"
 	"github.com/parnurzeal/gorequest"
-	"strconv"
 )
 
 /////////////////// MANUAL DEPLOYMENT ///////////////////
@@ -300,23 +302,28 @@ type Stack struct {
 	Weight       int64  `json:"weight,omitempty"`
 }
 
-func ListStacks(delimitedDcs string, delimitedNamespaces string, delimitedStatuses string, http *gorequest.SuperAgent, cfg *Config) (list []Stack, err []error) {
+func ListStacks(delimitedDcs string, delimitedNamespaces string, delimitedStatuses string, unit string, http *gorequest.SuperAgent, cfg *Config) (list []Stack, err []error) {
 	uri := "/v1/deployments?"
+	qs := url.Values{}
 	// set the datacenters if specified
 	if isValidCommaDelimitedList(delimitedDcs) {
-		uri = uri + "dc=" + delimitedDcs + "&"
+		qs.Set("dc", delimitedDcs)
 	}
 	if isValidCommaDelimitedList(delimitedStatuses) {
-		uri = uri + "status=" + delimitedStatuses + "&"
+		qs.Set("status", delimitedStatuses)
 	} else {
 		// if the user didnt specify statuses, they probally want all the stacks except historical terminated ones.
-		uri = uri + "status=pending,deploying,warming,ready,deprecated,failed&"
+		qs.Set("status", "pending,deploying,warming,ready,deprecated,failed")
 	}
 	if isValidCommaDelimitedList(delimitedNamespaces) {
-		uri = uri + "ns=" + delimitedNamespaces
+		qs.Set("ns", delimitedNamespaces)
 	} else {
-		uri = uri + "ns=dev,qa,prod"
+		qs.Set("ns", "dev,qa,prod")
+	}
+	if unit != "" {
+		qs.Set("unit", unit)
 	}
+	uri = uri + qs.Encode()
 
 	r, bytes, errs := AugmentRequest(
 		http.Get(cfg.Endpoint+uri), cfg).EndBytes()