Release/0.1.3#17
Merged
Merged
Conversation
pnpm has no native 'version' command and proxies to npm; with devEngines.packageManager.onFail='error', every npm invocation (including 'pnpm version') hard-failed with EBADDEVENGINES. Using 'warn' keeps pnpm as the declared package manager while unblocking version/release commands. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
pnpm has no native 'version' command and proxies to npm; the devEngines.packageManager guard caused every npm invocation (including 'pnpm version') to emit EBADDEVENGINES. pnpm remains the declared package manager via the 'packageManager' field (used by corepack). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the package version to 1.0.3 and removes the devEngines configuration from package.json. The reviewer suggests that instead of removing the devEngines block, it should be updated to a valid stable version of pnpm to ensure a consistent development environment for all contributors.
I am having trouble creating individual review comments. Click here to see my feedback.
package.json (17-23)
Removing the devEngines block eliminates the enforcement of the package manager version for developers. The version previously specified (11.1.2) appears to be invalid as pnpm 11 has not been released. Instead of removing the block, it is recommended to correct the version to a valid stable release (e.g., 9.x.x) to ensure all contributors use a consistent environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need help on this PR? Tag
@codesmithwith what you need.