Making shell scripts POSIX compliant (#2015)

* feat: usage of rsync for backups

* refactor: making scripts POSIX compliant

Author: sergey3bv

scripts/linux-aarch64/install.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 ALBYHUB_URL="https://getalby.com/install/hub/server-linux-aarch64.tar.bz2"
 VERIFIER_URL="https://getalby.com/install/hub/verify.sh"
@@ -8,18 +8,19 @@ echo "⚡️ Welcome to Alby Hub"
 echo "-----------------------------------------"
 echo "Installing Alby Hub"
 echo ""
-read -p "Absolute install directory path (default: $HOME/albyhub): " USER_INSTALL_DIR
+printf "Absolute install directory path (default: %s/albyhub): " "$HOME"
+read USER_INSTALL_DIR
 
 INSTALL_DIR="${USER_INSTALL_DIR:-$HOME/albyhub}"
 
 # create installation directory
-mkdir -p $INSTALL_DIR
-cd $INSTALL_DIR
+mkdir -p "$INSTALL_DIR"
+cd "$INSTALL_DIR" || exit 1
 
 # download and extract the Alby Hub executable
-wget $ALBYHUB_URL
+wget "$ALBYHUB_URL"
 
-if [[ ! -f "verify.sh" ]]; then
+if [ ! -f "verify.sh" ]; then
   echo "Downloading the verification script..."
   if ! wget -q "$VERIFIER_URL"; then
     echo "❌ Failed to download the verification script." >&2
@@ -28,53 +29,54 @@ if [[ ! -f "verify.sh" ]]; then
   chmod +x verify.sh
 fi
 
-./verify.sh server-linux-aarch64.tar.bz2 albyhub-Server-Linux-aarch64.tar.bz2
-if [[ $? -ne 0 ]]; then
+if ! ./verify.sh server-linux-aarch64.tar.bz2 albyhub-Server-Linux-aarch64.tar.bz2; then
   echo "❌ Verification failed, aborting installation"
   exit 1
 fi
 
-tar xvf server-linux-aarch64.tar.bz2
-if [[ $? -ne 0 ]]; then
+if ! tar xvf server-linux-aarch64.tar.bz2; then
   echo "Failed to unpack Alby Hub. Potentially bzip2 is missing"
   echo "Install it with sudo apt-get install bzip2"
-  exit
+  exit 1
 fi
 
 rm server-linux-aarch64.tar.bz2
 
 # prepare the data directory. this is pesistent and will hold all important data
-mkdir -p $INSTALL_DIR/data
+mkdir -p "$INSTALL_DIR/data"
 
 # create a simple start script that sets the default configuration variables
-tee $INSTALL_DIR/start.sh > /dev/null << EOF
-#!/bin/bash
+tee "$INSTALL_DIR/start.sh" > /dev/null << EOF
+#!/bin/sh
 
 echo "Starting Alby Hub"
 WORK_DIR="$INSTALL_DIR/data" LDK_GOSSIP_SOURCE="" $INSTALL_DIR/bin/albyhub
 EOF
-chmod +x $INSTALL_DIR/start.sh
+chmod +x "$INSTALL_DIR/start.sh"
 
 # add an update script to keep the Hub up to date
 # run this to update the hub
 wget https://raw.githubusercontent.com/getAlby/hub/master/scripts/linux-aarch64/update.sh
-chmod +x $INSTALL_DIR/update.sh
+chmod +x "$INSTALL_DIR/update.sh"
 
 echo ""
 echo ""
 echo "✅ Installation done."
 echo ""
 
 # optionally create a systemd service to start alby hub
-read -p "Do you want to setup a systemd service (requires sudo permission)? (y/n): " -n 1 -r
-if [[ ! $REPLY =~ ^[Yy]$ ]]
-then
-  echo ""
-  echo ""
-  echo "Run $INSTALL_DIR/start.sh to start Alby Hub"
-  echo "✅ DONE"
-  exit
-fi
+printf "Do you want to setup a systemd service (requires sudo permission)? (y/n): "
+read REPLY
+case "$REPLY" in
+  [Yy]*) ;;
+  *)
+    echo ""
+    echo ""
+    echo "Run $INSTALL_DIR/start.sh to start Alby Hub"
+    echo "✅ DONE"
+    exit
+    ;;
+esac
 
 sudo tee /etc/systemd/system/albyhub.service > /dev/null << EOF
 [Unit]

scripts/linux-aarch64/update.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 ALBYHUB_URL="https://getalby.com/install/hub/server-linux-aarch64.tar.bz2"
 echo ""
@@ -10,65 +10,67 @@ echo "You will have to unlock Alby Hub after the update."
 echo ""
 echo "Make sure you have your unlock password available and a backup of your seed."
 
-read -p "Do you want continue? (y/n):" -n 1 -r
-if [[ ! $REPLY =~ ^[Yy]$ ]]
-then
-  exit
-fi
+printf "Do you want continue? (y/n): "
+read REPLY
+case "$REPLY" in
+  [Yy]*) ;;
+  *) exit ;;
+esac
 echo ""
 
-sudo systemctl list-units --type=service --all | grep -Fq albyhub.service
-if [[ $? -eq 0 ]]; then
+if sudo systemctl list-units --type=service --all | grep -Fq albyhub.service; then
   echo "Stopping Alby Hub"
   sudo systemctl stop albyhub
 fi
 
-if pgrep -x "albyhub" > /dev/null
-then
+if pgrep -x "albyhub" > /dev/null; then
   echo "Alby Hub process is still running, stopping it now."
   pkill -f albyhub
 fi
 
 SCRIPT_DIR=$(dirname "$(readlink -f "$0")")
-read -p "Absolute install directory path (default: $SCRIPT_DIR): " USER_INSTALL_DIR
+printf "Absolute install directory path (default: %s): " "$SCRIPT_DIR"
+read USER_INSTALL_DIR
 echo ""
 
 INSTALL_DIR="${USER_INSTALL_DIR:-$SCRIPT_DIR}"
 
-if ! test -f $INSTALL_DIR/data/nwc.db; then
+if ! test -f "$INSTALL_DIR/data/nwc.db"; then
   echo "Could not find Alby Hub in this directory"
   exit 1
 fi
 
 
 echo "Running in $INSTALL_DIR"
 # make sure we run this in the install directory
-cd $INSTALL_DIR
+cd "$INSTALL_DIR" || exit 1
 
 echo "Cleaning up old backup"
 rm -rf albyhub-backup
 mkdir albyhub-backup
 
 echo "Creating current backup"
-mv bin albyhub-backup
-mv lib albyhub-backup
-cp -r data albyhub-backup
+if command -v rsync > /dev/null 2>&1; then
+  rsync -av data bin lib albyhub-backup/
+else
+  mv bin albyhub-backup
+  mv lib albyhub-backup
+  cp -r data albyhub-backup
+fi
 
 
 echo "Downloading latest version"
-wget $ALBYHUB_URL
+wget "$ALBYHUB_URL"
 
-./verify.sh server-linux-aarch64.tar.bz2 albyhub-Server-Linux-aarch64.tar.bz2
-if [[ $? -ne 0 ]]; then
+if ! ./verify.sh server-linux-aarch64.tar.bz2 albyhub-Server-Linux-aarch64.tar.bz2; then
   echo "❌ Verification failed, aborting installation"
   exit 1
 fi
 
 tar -xvf server-linux-aarch64.tar.bz2
 rm server-linux-aarch64.tar.bz2
 
-sudo systemctl list-units --type=service --all | grep -Fq albyhub.service
-if [[ $? -eq 0 ]]; then
+if sudo systemctl list-units --type=service --all | grep -Fq albyhub.service; then
   echo "Starting Alby Hub"
   sudo systemctl start albyhub
 fi

scripts/linux-x86_64/install.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 ALBYHUB_URL="https://getalby.com/install/hub/server-linux-x86_64.tar.bz2"
 VERIFIER_URL="https://getalby.com/install/hub/verify.sh"
@@ -8,18 +8,19 @@ echo "⚡️ Welcome to Alby Hub"
 echo "-----------------------------------------"
 echo "Installing Alby Hub"
 echo ""
-read -p "Absolute install directory path (default: $HOME/albyhub): " USER_INSTALL_DIR
+printf "Absolute install directory path (default: %s/albyhub): " "$HOME"
+read USER_INSTALL_DIR
 
 INSTALL_DIR="${USER_INSTALL_DIR:-$HOME/albyhub}"
 
 # create installation directory
-mkdir -p $INSTALL_DIR
-cd $INSTALL_DIR
+mkdir -p "$INSTALL_DIR"
+cd "$INSTALL_DIR" || exit 1
 
 # download and extract the Alby Hub executable
-wget $ALBYHUB_URL
+wget "$ALBYHUB_URL"
 
-if [[ ! -f "verify.sh" ]]; then
+if [ ! -f "verify.sh" ]; then
   echo "Downloading the verification script..."
   if ! wget -q "$VERIFIER_URL"; then
     echo "❌ Failed to download the verification script." >&2
@@ -28,53 +29,54 @@ if [[ ! -f "verify.sh" ]]; then
   chmod +x verify.sh
 fi
 
-./verify.sh server-linux-x86_64.tar.bz2 albyhub-Server-Linux-x86_64.tar.bz2
-if [[ $? -ne 0 ]]; then
+if ! ./verify.sh server-linux-x86_64.tar.bz2 albyhub-Server-Linux-x86_64.tar.bz2; then
   echo "❌ Verification failed, aborting installation"
   exit 1
 fi
 
-tar xvf server-linux-x86_64.tar.bz2
-if [[ $? -ne 0 ]]; then
+if ! tar xvf server-linux-x86_64.tar.bz2; then
   echo "Failed to unpack Alby Hub. Potentially bzip2 is missing"
   echo "Install it with sudo apt-get install bzip2"
-  exit
+  exit 1
 fi
 
 rm server-linux-x86_64.tar.bz2
 
 # prepare the data directory. this is pesistent and will hold all important data
-mkdir -p $INSTALL_DIR/data
+mkdir -p "$INSTALL_DIR/data"
 
 # create a simple start script that sets the default configuration variables
-tee $INSTALL_DIR/start.sh > /dev/null << EOF
-#!/bin/bash
+tee "$INSTALL_DIR/start.sh" > /dev/null << EOF
+#!/bin/sh
 
 echo "Starting Alby Hub"
 WORK_DIR="$INSTALL_DIR/data" LDK_GOSSIP_SOURCE="" $INSTALL_DIR/bin/albyhub
 EOF
-chmod +x $INSTALL_DIR/start.sh
+chmod +x "$INSTALL_DIR/start.sh"
 
 # add an update script to keep the Hub up to date
 # run this to update the hub
 wget https://raw.githubusercontent.com/getAlby/hub/master/scripts/linux-x86_64/update.sh
-chmod +x $INSTALL_DIR/update.sh
+chmod +x "$INSTALL_DIR/update.sh"
 
 echo ""
 echo ""
 echo "✅ Installation done."
 echo ""
 
 # optionally create a systemd service to start alby hub
-read -p "Do you want to setup a systemd service (requires sudo permission)? (y/n): " -n 1 -r
-if [[ ! $REPLY =~ ^[Yy]$ ]]
-then
-  echo ""
-  echo ""
-  echo "Run $INSTALL_DIR/start.sh to start Alby Hub"
-  echo "✅ DONE"
-  exit
-fi
+printf "Do you want to setup a systemd service (requires sudo permission)? (y/n): "
+read REPLY
+case "$REPLY" in
+  [Yy]*) ;;
+  *)
+    echo ""
+    echo ""
+    echo "Run $INSTALL_DIR/start.sh to start Alby Hub"
+    echo "✅ DONE"
+    exit
+    ;;
+esac
 
 sudo tee /etc/systemd/system/albyhub.service > /dev/null << EOF
 [Unit]