chore: migrate to eslint v10 (#2091)

* chore: migrate to eslint v10

* fix: linting issues

Author: im-adithya

frontend/eslint.config.mjs

@@ -1,20 +1,10 @@
-import { fixupConfigRules, fixupPluginRules } from "@eslint/compat";
-import { FlatCompat } from "@eslint/eslintrc";
-import js from "@eslint/js";
-import typescriptEslint from "@typescript-eslint/eslint-plugin";
+import eslint from "@eslint/js";
 import tsParser from "@typescript-eslint/parser";
+import eslintConfigPrettier from "eslint-config-prettier/flat";
+import reactHooks from "eslint-plugin-react-hooks";
 import reactRefresh from "eslint-plugin-react-refresh";
 import globals from "globals";
-import path from "node:path";
-import { fileURLToPath } from "node:url";
-const __filename = fileURLToPath(import.meta.url);
-const __dirname = path.dirname(__filename);
-
-const compat = new FlatCompat({
-  baseDirectory: __dirname,
-  recommendedConfig: js.configs.recommended,
-  allConfig: js.configs.all,
-});
+import tseslint from "typescript-eslint";
 
 export default [
   {
@@ -25,20 +15,12 @@ export default [
       "src/components/ui/navigation-menu.tsx",
     ],
   },
-  ...fixupConfigRules(
-    compat.extends(
-      "eslint:recommended",
-      "plugin:@typescript-eslint/recommended",
-      "plugin:react-hooks/recommended",
-      "prettier"
-    )
-  ),
+  eslint.configs.recommended,
+  ...tseslint.configs.recommended,
+  reactRefresh.configs.vite,
+  reactHooks.configs.flat["recommended-latest"],
+  eslintConfigPrettier,
   {
-    plugins: {
-      "react-refresh": reactRefresh,
-      "@typescript-eslint": fixupPluginRules(typescriptEslint),
-    },
-
     languageOptions: {
       globals: {
         ...globals.browser,
@@ -48,20 +30,6 @@ export default [
     },
     files: ["**/*.ts", "**/*.tsx"],
     rules: {
-      "react-refresh/only-export-components": [
-        "warn",
-        {
-          allowConstantExport: true,
-        },
-      ],
-
-      "@typescript-eslint/ban-ts-comment": [
-        "error",
-        {
-          "ts-ignore": "allow-with-description",
-        },
-      ],
-
       "@typescript-eslint/no-unused-vars": [
         "warn",
         {

frontend/package.json

@@ -66,9 +66,8 @@
   "devDependencies": {
     "@commitlint/cli": "^19.3.0",
     "@commitlint/config-conventional": "^20.0.0",
-    "@eslint/compat": "^1.0.3",
-    "@eslint/eslintrc": "^3.1.0",
-    "@eslint/js": "^9.4.0",
+    "@eslint/eslintrc": "^3.3.4",
+    "@eslint/js": "^10.0.1",
     "@tailwindcss/aspect-ratio": "^0.4.2",
     "@tailwindcss/forms": "^0.5.7",
     "@tailwindcss/typography": "^0.5.19",
@@ -77,20 +76,19 @@
     "@types/react": "^18.2.15",
     "@types/react-dom": "^18.2.7",
     "@types/react-lottie": "^1.2.10",
-    "@typescript-eslint/eslint-plugin": "^7.11.0",
-    "@typescript-eslint/parser": "^7.11.0",
     "@vitejs/plugin-react-swc": "^3.3.2",
-    "eslint": "^9.4.0",
+    "eslint": "^10.0.2",
     "eslint-config-prettier": "^10.1.8",
     "eslint-plugin-react-hooks": "^7.0.1",
-    "eslint-plugin-react-refresh": "^0.4.3",
+    "eslint-plugin-react-refresh": "^0.5.2",
     "globals": "^15.4.0",
     "husky": "^9.0.11",
     "lint-staged": "^15.2.5",
     "prettier": "3.6.2",
     "shx": "^0.4.0",
     "tailwindcss": "^4.1.16",
     "typescript": "^5.9.3",
+    "typescript-eslint": "^8.56.1",
     "vite": "^5.4.0",
     "vite-plugin-pwa": "^1.2.0",
     "vite-tsconfig-paths": "^6.1.1"

frontend/src/components/ExecuteCustomNodeCommandDialogContent.tsx

@@ -32,7 +32,7 @@ export function ExecuteCustomNodeCommandDialogContent({
       null,
       2
     );
-  } catch (error) {
+  } catch {
     // ignore unexpected json
   }
 

frontend/src/components/home/widgets/AppOfTheDayWidget.tsx

@@ -12,7 +12,7 @@ import { LinkButton } from "src/components/ui/custom/link-button";
 
 export function AppOfTheDayWidget() {
   function seededRandom(seed: number) {
-    const x = Math.sin(seed++) * 10000;
+    const x = Math.sin(seed) * 10000;
     return x - Math.floor(x);
   }
 

frontend/src/components/layouts/SettingsLayout.tsx

@@ -134,7 +134,7 @@ export default function SettingsLayout() {
   );
 }
 
-const MenuItem = ({
+export const MenuItem = ({
   to,
   children,
 }: {
@@ -159,5 +159,3 @@ const MenuItem = ({
     </NavLink>
   </>
 );
-
-MenuItem;

frontend/src/components/ui/theme-provider.tsx

@@ -1,6 +1,7 @@
 import { createContext, useContext, useEffect, useState } from "react";
 
 export type DarkMode = "system" | "light" | "dark";
+// eslint-disable-next-line react-refresh/only-export-components
 export const Themes = [
   "default",
   "alby",
@@ -71,7 +72,7 @@ export function ThemeProvider({
 
     classList.add(`theme-${theme}`);
 
-    let prefersDark = false;
+    let prefersDark;
     if (darkMode == "system") {
       prefersDark = window.matchMedia("(prefers-color-scheme: dark)").matches;
     } else {

frontend/src/lib/clipboard.ts

@@ -27,7 +27,7 @@ export async function copyToClipboard(content: string) {
   try {
     await copyPromise;
     toast.success("Copied to clipboard");
-  } catch (e) {
+  } catch {
     toast.error("Failed to copy to clipboard");
   }
 }

frontend/src/screens/channels/Channels.tsx

@@ -134,7 +134,7 @@ export default function Channels() {
           id: channel.id,
           message: "Unconfirmed for " + unconfirmedHours + " hours",
         });
-      } catch (error) {
+      } catch {
         _longUnconfirmedZeroConfChannels.push({
           id: channel.id,
           message: "Channel transaction not in the mempool yet",

frontend/src/screens/internal-apps/Bitrefill.tsx

@@ -34,7 +34,7 @@ export function Bitrefill() {
             const invoice = new Invoice({ pr: parsedData.paymentAddress });
             setInvoice(invoice);
           }
-        } catch (e) {
+        } catch {
           /* empty */
         }
       }

frontend/src/screens/settings/Backup.tsx

@@ -63,7 +63,7 @@ export default function Backup() {
 
       setDecryptedMnemonic(result?.mnemonic ?? "");
       setIsDialogOpen(true);
-    } catch (error) {
+    } catch {
       toast.error("Incorrect password", {
         description: "Failed to decrypt recovery phrase.",
       });