add some rules

[anbraten]

• Most / all linter warnings should be errors
• https://eslint.org/docs/rules/object-shorthand set to always
• force functions to be arrow functions if they have just a single return line
• force const instead of let if possible
• space behind comment start??? force // ... instead of //...
• force new-line before it-test (not if behind describe)
• stop cyclic imports (https://github.com/benmosher/eslint-plugin-import/blob/v2.22.0/docs/rules/no-cycle.md)
• declare variable before using it
• prevent if (x) { return true } else { return false }

[lukashass]

@anbraten What do you think of https://eslint.org/docs/rules/func-style#expression?

[lukashass]

declare variable before using it

Isn't this handled by typescript?

[anbraten]

declare variable before using it

Isn't this handled by typescript?

@lukashass It wasn't the last time I checked it. Anyways, Typescript should not be responsible for these kind of code quality checking as that stops the build from passing which is quite annoying while developing.

[anbraten]

@anbraten What do you think of https://eslint.org/docs/rules/func-style#expression?

@lukashass IDK. The first sample seems to be quite restrictive and would require us to change a lot of code as we often use function xyz(){] inside vue setup.

[lukashass]

declare variable before using it

Isn't this handled by typescript?

@lukashass It wasn't the last time I checked it. Anyways, Typescript should not be responsible for these kind of code quality checking as that stops the build from passing which is quite annoying while developing.

@anbraten Should be handled by eslint now (978fb72).

[lukashass]

@anbraten What do you think of https://eslint.org/docs/rules/func-style#expression?

@lukashass IDK. The first sample seems to be quite restrictive and would require us to change a lot of code as we often use function xyz(){] inside vue setup.

Just though it would be nice for consistency and this would have fixed some "use before define" issues as well:

The primary difference between function declarations and function expressions is that declarations are hoisted to the top of the scope in which they are defined, which allows you to write code that uses the function before its declaration.

But that is now restricted by @typescript-eslint/no-use-before-define ✨