finishDraw method implementation

[clavijojuan]

Hi,

First of all i want to say that this is a excellent plugin.

The issue is to ask if is possible add "finishDraw" method because "map.pm.disableDraw();" is stoping draw mode and removing all the "temporal layers" but i want stop and save them programmatically.

Thanks.

[Falke-Design]

As workaround you can call map.pm.Draw.Line._finishShape()

[clavijojuan]

As workaround you can call map.pm.Draw.Line._finishShape()

Yeah, i found this in line type definition file, thanks.

Maybe should be added on README documentation. I think that is an important method.

Another think:
When you create a custom control using "map.pm.Toolbar.copyDrawControl()" with specific name and then use
map.pm.Draw[CUSTOM NAME]._finishShape()` it generates an error in typescript.

[Falke-Design]

Maybe should be added on README documentation

No because it is a internal private function. And because of this the TypeScript error is valid too.

I see the benefit, we will add this function in one of the next releases

[clavijojuan]

No because it is a internal private function. And because of this the TypeScript error is valid too.

I see the benefit, we will add this function in one of the next releases

Ok thanks 👍

[raopengfei]

As workaround you can call map.pm.Draw.Line._finishShape()

When drawing circles and rectangles, you need the event parameter, including the latlng attribute. I do this temporarily, and other shapes can be ignored.

e.latlng = this.map.pm.Draw[shape]._hintMarker.getLatLng(); this.map.pm.Draw[shape]._finishShape(e)

[jayli3n]

I see the benefit, we will add this function in one of the next releases

Hi there, just wondering if this (finishShape) made it to the release?

[denizmaral]

I did it but it created each time a new instance of lastly created layer;

      document.addEventListener('keydown', e => {
        if (e.key === 'Enter' || e.key === "Escape") {

          map.pm.Draw.Line._finishShape();
          console.log('Enter pressed → simulated to finish drawing');
        }
      });