Skip to content

Commit 49a4e22

Browse files
authored
Merge pull request #442 from geolonia/413-workaround-mocha-incompatibility
(refs #413) Fix CI test failure on Node.js 22.18+ by disabling experimental type stripping
2 parents 052b80d + 75497cb commit 49a4e22

File tree

5 files changed

+12
-6
lines changed

5 files changed

+12
-6
lines changed

.github/workflows/build.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727
runs-on: ubuntu-latest
2828
strategy:
2929
matrix:
30-
node-version: ['18.x']
30+
node-version: ['22.x']
3131
steps:
3232
- uses: actions/checkout@v4
3333
- name: Use Node.js ${{ matrix.node-version }}
@@ -64,7 +64,7 @@ jobs:
6464
- uses: actions/checkout@v4
6565
- uses: actions/setup-node@v4
6666
with:
67-
node-version: '18.x'
67+
node-version: '22.x'
6868
- name: Clean repo
6969
run: |
7070
git checkout --orphan gh-pages
@@ -95,7 +95,7 @@ jobs:
9595
- uses: actions/setup-node@v4
9696
with:
9797
tag_name: 'v%s'
98-
node-version: '18.x'
98+
node-version: '22.x'
9999
registry-url: 'https://registry.npmjs.org'
100100
scope: '@geolonia'
101101
- name: load the built

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v18
1+
v22

.tool-versions

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
nodejs 18.16.0
1+
nodejs 22.21.0

README.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,12 @@ You can see more examples at [https://geolonia.github.io/embed/](https://geoloni
4646

4747
## Development
4848

49+
### Requirements
50+
51+
- node.js >= 22.18
52+
53+
### How to build
54+
4955
```shell
5056
$ git clone git@github.com:geolonia/embed.git
5157
$ cd embed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"analyze": "ANALYZE=true webpack --mode production",
1515
"format": "prettier-eslint \"./src/**/*.ts\" --write",
1616
"lint": "eslint --ext .js,.cjs,.mjs,.jsx,.ts,.tsx .",
17-
"test": "TS_NODE_COMPILER_OPTIONS='{\"module\": \"commonjs\" }' mocha",
17+
"test": "TS_NODE_COMPILER_OPTIONS='{\"module\": \"commonjs\" }' NODE_OPTIONS=\"--no-experimental-strip-types\" mocha",
1818
"e2e": "playwright test"
1919
},
2020
"author": "Geolonia (https://geolonia.com)",

0 commit comments

Comments
 (0)