Skip to content

Crash in commit_contains_correct_signoff (AttributeError: 'NoneType' object has no attribute 'lower') #5

@thesamesam

Description

@thesamesam

After upgrading from 7d53984 to 7c507e8 on infra, I see:

AttributeError: 'NoneType' object has no attribute 'lower'
Traceback (most recent call last):
  File "/opt/prassign/assign-pull-requests.py", line 421, in <module>
    sys.exit(main(*sys.argv[1:]))
             ^^^^^^^^^^^^^^^^^^^
  File "/opt/prassign/assign-pull-requests.py", line 124, in main
    assign_one(pr_getter, issue, dev_mapping, proj_mapping, categories,
  File "/opt/prassign/assign-pull-requests.py", line 372, in assign_one
    missing_signoff = not all(commit_contains_correct_signoff(c) for c in pr.get_commits())
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/prassign/assign-pull-requests.py", line 372, in <genexpr>
    missing_signoff = not all(commit_contains_correct_signoff(c) for c in pr.get_commits())
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/prassign/assign-pull-requests.py", line 142, in commit_contains_correct_signoff
    committer_email = commit.committer.email.lower()  # case insensitive
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'lower'

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions