Merge pull request #72 from ktaletsk/create-cmd-improvements

Improvements to 'create' CLI command: rename type arg and add error handling

Author: martindurant

src/projspec/__main__.py

@@ -163,10 +163,26 @@ def create(type, path):
     (Path must be local, no storage_options)
     """
     from projspec.proj import Project
+    from projspec.proj.base import ProjectSpec, registry
 
+    if type not in registry:
+        print(f"Unknown spec type: {type}")
+        sys.exit(1)
     proj = Project(path)
     if type not in proj:
-        files = proj.create(type)
+        try:
+            files = proj.create(type)
+        except NotImplementedError:
+            supported = sorted(
+                name
+                for name, cls in registry.items()
+                if cls._create is not ProjectSpec._create
+            )
+            print(
+                f"Spec type '{type}' does not support creation.\n"
+                f"Types that support creation: {', '.join(supported)}"
+            )
+            sys.exit(1)
         for afile in files:
             print(afile)
     else:

src/projspec/utils.py

@@ -390,7 +390,11 @@ def class_infos():
 
     return {
         "specs": {
-            name: {"doc": cls.__doc__, "link": cls.spec_doc}
+            name: {
+                "doc": cls.__doc__,
+                "link": cls.spec_doc,
+                "create": cls._create is not projspec.ProjectSpec._create,
+            }
             for name, cls in projspec.proj.base.registry.items()
         },
         "content": {

tests/test_cli.py

@@ -81,3 +81,13 @@ def test_library(temp_conf_dir, capsys):
     main(["library", "delete", path], standalone_mode=False)
     main(["library", "list"], standalone_mode=False)
     assert capsys.readouterr().out == ""
+
+
+def test_create_cant(tmpdir, capsys):
+    try:
+        main(["create", "project_extra", str(tmpdir)], standalone_mode=False)
+    except SystemExit:
+        pass
+    out = capsys.readouterr().out
+    assert "does not support creation" in out
+    assert "python_code" in out