After Printing PDF using chromium pdf generator, the scrolling is fixed to the pdf page's height

[architectcoding]

HI, I have observed a bug which happens sometimes after generating pdf print using chromium pdf.
For example, if I create a sales order, then tried to print it. It is no problem, but back to the sales order and the scrolling height will be limited to the pdf height, so I cannot see the whole Sales Order module, and will require a full refresh of the web to restore the original height. This is very troublesome.

Before printing: please take a note of the scroll height

Printing:

Back to the sales order page: as you can see the scrolling is kept as the printing page's height, so I need to make a full page refresh to restore it.

Versions:
Frappe Framework: v16.10.10 (version-16)
ERPNext: v16.8.1 (version-16)
Frappe HR: v16.4.2 (version-16)
Print Designer: v1.6.7 (main)

[iamejaaz]

@KerollesFathy, would you mind taking a look at this issue when you have a chance?

[KerollesFathy]

@KerollesFathy, would you mind taking a look at this issue when you have a chance?

I will do 👍

[KerollesFathy]

Hi @iamejaaz

After Debugging session

when returning to the Sales Order form view, the print page element already exists in the DOM, which affects the scroll behavior.

To fix this, I bound a hide event and remove the page-print:

$(wrapper).bind("hide", () => {
     $("#page-print").remove();
 });

after doing this, the form behaves correctly

[KerollesFathy]

when change the display: none to display:block

[KerollesFathy]

@iamejaaz I think this should transfer to print_designer