Refactor: Remove dead SPI methods and avoid hardcoded test frequencies

Author: TejasAnalyst

pslab/bus/spi.py

@@ -214,29 +214,6 @@ def _get_parameters(cls) -> Tuple[int]:
             cls._smp,
         )
 
-    def _start(self):
-        """Select SPI channel to enable.
-
-        Basically sets the relevant chip select pin to LOW.
-
-        External ChipSelect pins:
-            version < 5 : {6, 7} # RC5, RC4 (dropped support)
-            version == 5 : {} (don't have any external CS pins)
-            version == 6 : {7} # RC4
-        """
-        self._device.send_byte(CP.SPI_HEADER)
-        self._device.send_byte(CP.START_SPI)
-        self._device.send_byte(7)  # SPI.CS v6
-        # No ACK because `RESPONSE == DO_NOT_BOTHER` in firmware.
-
-    def _stop(self):
-        """Select SPI channel to disable.
-
-        Sets the relevant chip select pin to HIGH.
-        """
-        self._device.send_byte(CP.SPI_HEADER)
-        self._device.send_byte(CP.STOP_SPI)
-        self._device.send_byte(7)  # SPI.CS v6
 
     def _transfer(self, data: int, bits: int) -> int:
         """Send data over SPI and receive data from SPI simultaneously.

tests/test_spi.py

@@ -31,7 +31,6 @@
 SPIMaster._primary_prescaler = PPRE = 0
 SPIMaster._secondary_prescaler = SPRE = 0
 # Static value 100kHz used because instance property '_frequency' cannot be accessed on the class.
-PWM_FREQUENCY = 100000.0
 MICROSECONDS = 1e-6
 RELTOL = 0.05
 # Number of expected logic level changes.
@@ -60,9 +59,11 @@ def slave(handler: SerialHandler) -> SPISlave:
 
 
 @pytest.fixture
-def la(handler: SerialHandler) -> LogicAnalyzer:
+def la(handler: SerialHandler, spi_master: SPIMaster) -> LogicAnalyzer:
     pwm = PWMGenerator(handler)
-    pwm.generate(SDI[1], PWM_FREQUENCY, 0.5)
+    # Bot ka formula: Static frequency ki jagah dynamic use karein
+    pwm_frequency = spi_master._frequency * 2 / 3
+    pwm.generate(SDI[1], pwm_frequency, 0.5)
     return LogicAnalyzer(handler)
 
 

tests/test_uart.py

@@ -17,7 +17,6 @@
 TXD2 = "LA1"
 RXD2 = "SQ1"
 # Static value 500kHz (half of default 1MHz baudrate) used as instance property cannot be accessed here.
-PWM_FREQUENCY = 500000.0
 MICROSECONDS = 1e-6
 RELTOL = 0.05
 # Number of expected logic level changes.
@@ -37,10 +36,11 @@ def la(handler: SerialHandler) -> LogicAnalyzer:
 
 
 @pytest.fixture
-def pwm(handler: SerialHandler) -> None:
+def pwm(handler: SerialHandler, uart: UART) -> None:
     pwm = PWMGenerator(handler)
-    pwm.generate(RXD2, PWM_FREQUENCY, 0.5)
-
+    # 500000.0 ki jagah dynamic formula
+    pwm_frequency = uart._baudrate / 2.0
+    pwm.generate(RXD2, pwm_frequency, 0.5)
 
 def test_configure(la: LogicAnalyzer, uart: UART):
     baudrate = 1000000