Skip to content

Commit fa0c6c0

Browse files
committed
minor refactors. and fixed alignment for threads with less than 50 entries
1 parent c08a0e1 commit fa0c6c0

File tree

3 files changed

+29
-14
lines changed

3 files changed

+29
-14
lines changed

ComicVine.API/README.md

Lines changed: 23 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,26 @@
55
- Provides restful api for querying posts, threads, user profiles and more
66

77
## TODO
8-
- better styling
9-
- response UI
10-
- refactor internals
11-
- add search
12-
- add polling worker
13-
- add stats
14-
- default error pages for both api and web interface
15-
- better styling for api documentation
16-
- more documentation for api
17-
- refactors for thread and post view on user profile (and errors for deactivated accounts)
18-
- sorting of threads
19-
- added footer linking to api on forums
20-
- make images and blogs on user profile optional
8+
-[ ] better styling
9+
-[ ] responsive UI
10+
-[ ] refactor internals
11+
-[ ] add time stamp to posts
12+
-[ ] add search
13+
-[x] add polling worker
14+
-[ ] add stats
15+
-[ ] default error pages for both api and web interface
16+
-[ ] better styling for api documentation
17+
-[ ] more documentation for api
18+
-[ ] refactors for thread and post view on user profile (and errors for deactivated accounts)
19+
-[ ] ability to sort threads by different criteria
20+
-[ ] added footer linking to api on forums
21+
-[ ] make images and blogs on user profile optional
22+
23+
## Archives TODO
24+
-[x] sorting of threads by no of posts
25+
-[ ] sorting of posts by date created
26+
-[ ] thread should have a link to the og post on cv
27+
-[ ] higlights for deleted posts
28+
-[ ] posts view in user profile should have link to the thread
29+
-[ ] there should be a way to link to a specific post in a thread
30+
-[ ] clicking on post user's post view should link to the post in thread

ComicVine.API/wwwroot/css/main.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ footer {
7676
/*padding: 1em;*/
7777
display: grid;
7878
grid-template-columns: 3em 1fr 10em 10em 4em 4em;
79+
align-content: start;
7980
}
8081
#thread-container > span:not(div:last-child) {
8182
border-right: 1px solid #d1d4d6;

VinePlus.Core/Parsers.fs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,15 @@ module Parsers =
3030
type Link =
3131
{ Text: string; Link: string }
3232
/// A post made on a thread. this also includes the OP
33+
/// marked as cli mutable because efcore needs it to have a constructor with getters and setters
3334
[<CLIMutable>]
3435
type Post =
3536
{
3637
Id: string; IsComment: bool; IsDeleted: bool; IsModComment: bool; PostNo: int;
3738
Creator: Link; IsEdited: bool; Created: DateTime; Content: string; ThreadId: int
3839
}
3940
/// A thread created on comicvine
41+
/// marked as cli mutable because efcore needs it to have a constructor with getters and setters
4042
[<CLIMutable>]
4143
type Thread =
4244
{
@@ -76,11 +78,13 @@ module Parsers =
7678
{ Follower: Link; Avatar: string }
7779

7880
/// a table on the db that keeps track of how many threads/posts are created regularly
81+
/// marked as cli mutable because efcore needs it to have a constructor with getters and setters
82+
[<CLIMutable>]
7983
type Info =
8084
{
8185
NewThreads: int
8286
NewPosts: int
83-
DeletedPosts: int
87+
Date: DateTime
8488
}
8589

8690
/// function that can parse a page

0 commit comments

Comments
 (0)