feat: no cds for known eval (#2377)

Author: EagleoutIce

src/dataflow/graph/graph.ts

@@ -519,17 +519,16 @@ export class DataflowGraph<
 		to = NodeId.normalize(to);
 		const vertex = this.getVertex(from);
 		guard(vertex !== undefined, () => `node must be defined for ${from} to add control dependency`);
-		vertex.cds ??= [];
-		let hasControlDependency = false;
-		for(const { id, when: cond } of vertex.cds) {
-			if(id === to && when !== cond) {
-				hasControlDependency = true;
-				break;
+		if(vertex.cds) {
+			for(const { id, when: cond } of vertex.cds) {
+				if(id === to && when !== cond) {
+					return this;
+				}
 			}
+		} else {
+			vertex.cds = [];
 		}
-		if(!hasControlDependency) {
-			vertex.cds.push({ id: to, when });
-		}
+		vertex.cds.push({ id: to, when });
 		return this;
 	}
 

src/dataflow/internal/process/functions/call/built-in/built-in-eval.ts

@@ -78,14 +78,14 @@ export function processEvalCall<OtherInfo>(
 
 		data = {
 			...data,
-			cds: [...(data.cds ?? []), { id: rootId, when: true }]
+			cds: code.length > 1 ? [...(data.cds ?? []), { id: rootId, when: true }] : data.cds
 		};
 		const originalInfo = { ...information };
 
 		const result: DataflowInformation[] = [];
 		for(const c of code) {
 			const codeRequest = requestFromInput(c);
-			const r = sourceRequest(rootId, codeRequest, data, originalInfo, idGenerator);
+			const r = sourceRequest(rootId, codeRequest, data, originalInfo, code.length > 1, idGenerator);
 			result.push(r);
 			// add a returns edge from the eval to the result
 			for(const e of r.exitPoints) {

src/dataflow/internal/process/functions/call/built-in/built-in-source.ts

@@ -31,6 +31,7 @@ import { resolveIdToValue } from '../../../../../eval/resolve/alias-tracking';
 import type { ReadOnlyFlowrAnalyzerContext } from '../../../../../../project/context/flowr-analyzer-context';
 import type { RProjectFile } from '../../../../../../r-bridge/lang-4.x/ast/model/nodes/r-project';
 import { BuiltInProcName } from '../../../../../environments/built-in';
+import { EdgeType } from '../../../../../graph/edge';
 
 /**
  * Infers working directories based on the given option and reference chain
@@ -210,7 +211,7 @@ export function processSourceCall<OtherInfo>(
 				result = sourceRequest(rootId, {
 					request: 'file',
 					content: f
-				}, data, result, sourcedDeterministicCountingIdGenerator((findCount > 0 ? findCount + '::' : '') + f, name.location));
+				}, data, result, true, sourcedDeterministicCountingIdGenerator((findCount > 0 ? findCount + '::' : '') + f, name.location));
 			}
 			return result;
 		}
@@ -225,7 +226,7 @@ export function processSourceCall<OtherInfo>(
  * Processes a source request with the given dataflow processor information and existing dataflow information
  * Otherwise, this can be an {@link RProjectFile} representing a standalone source file
  */
-export function sourceRequest<OtherInfo>(rootId: NodeId, request: RParseRequest | RProjectFile<OtherInfo & ParentInformation>, data: DataflowProcessorInformation<OtherInfo & ParentInformation>, information: DataflowInformation, getId?: IdGenerator<NoInfo>): DataflowInformation {
+export function sourceRequest<OtherInfo>(rootId: NodeId, request: RParseRequest | RProjectFile<OtherInfo & ParentInformation>, data: DataflowProcessorInformation<OtherInfo & ParentInformation>, information: DataflowInformation, makeMaybe: boolean, getId?: IdGenerator<NoInfo>): DataflowInformation {
 	// parse, normalize and dataflow the sourced file
 	let dataflow: DataflowInformation;
 	let fst: RProjectFile<OtherInfo & ParentInformation>;
@@ -276,11 +277,20 @@ export function sourceRequest<OtherInfo>(rootId: NodeId, request: RParseRequest
 
 	// take the entry point as well as all the written references, and give them a control dependency to the source call to show that they are conditional
 	if(!String(rootId).startsWith('file-')) {
-		if(dataflow.graph.hasVertex(dataflow.entryPoint)) {
-			dataflow.graph.addControlDependency(dataflow.entryPoint, rootId, true);
-		}
-		for(const out of dataflow.out) {
-			dataflow.graph.addControlDependency(out.nodeId, rootId, true);
+		if(makeMaybe) {
+			if(dataflow.graph.hasVertex(dataflow.entryPoint)) {
+				dataflow.graph.addControlDependency(dataflow.entryPoint, rootId, true);
+			}
+			for(const out of dataflow.out) {
+				dataflow.graph.addControlDependency(out.nodeId, rootId, true);
+			}
+		} else {
+			if(dataflow.graph.hasVertex(dataflow.entryPoint)) {
+				dataflow.graph.addEdge(dataflow.entryPoint, rootId, EdgeType.Reads);
+			}
+			for(const out of dataflow.out) {
+				dataflow.graph.addEdge(out.nodeId, rootId, EdgeType.Reads);
+			}
 		}
 	}
 
@@ -319,5 +329,5 @@ export function standaloneSourceFile<OtherInfo>(
 		...data,
 		environment:    information.environment,
 		referenceChain: [...data.referenceChain, file.filePath]
-	}, information);
+	}, information, false);
 }