Respect baseUri for static Targets

[paavo]

it looks like baseUri is ignored when using a GcsTarget as static target @kdambekalns

Neos:
  Flow:
    resource:
      targets:
        googleStaticResourcesTarget:
          target: 'Flownative\Google\CloudStorage\GcsTarget'
          targetOptions:
            bucket: '%env:CLOUDSTORAGE_S3_BUCKET%'
            keyPrefix: 'statictarget/'
            baseUri: '%env:CLOUDSTORAGE_S3_PUBLICURL%'
            

Neos:
  Flow:
    resource:
      collections:
        static:
          target: 'googleStaticResourcesTarget'

[paavo]

persistentResourceUris.pattern could help 🤔

[paavo]

Looks like persistentResourceUris pattern is ignored too 🙈

            persistentResourceUris:
              pattern: '{baseUri}{sha1}/{filename}' 

[kdambekalns]

Yes, static resource URIs are built like this: https://github.com/flownative/flow-google-cloudstorage/blob/5.3.1/Classes/GcsTarget.php#L434-L438

Slightly simpler compared to persistent URIs: https://github.com/flownative/flow-google-cloudstorage/blob/5.3.1/Classes/GcsTarget.php#L539-L578

Why is this usually not bad? Your webserver should be very fast when delivering static files. So the response time largely depends on how good the network connection is. In that case using GCS with a CDN can be faster, if your distance to the CDN edge location makes a difference. Without a CDN GCS is usually slower for static resources.

But of course the hardcoded

'https://storage.googleapis.com/' . $this->bucketName . '/' . $this->keyPrefix . $relativePathAndFilename;

could be a bit more flexible…