Skip to content

Commit 94b4646

Browse files
committed
fix(lint): Acknowledge discarded print and close return values
errcheck flagged unchecked returns throughout the CLI's output paths and response cleanup. Those returns are never actionable in practice: console writes only fail on broken pipe or a full disk, and a deferred network resource close has nothing useful to do with the error. Discard them explicitly rather than silencing the linter, so any genuinely unchecked error elsewhere stays visible. Add lint to the `make qa` target so the release flow catches this locally rather than only in CI.
1 parent c3b39b4 commit 94b4646

3 files changed

Lines changed: 95 additions & 95 deletions

File tree

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ help:
1717
@echo "make fmt-check - Check gofmt formatting"
1818
@echo "make vet - Run go vet"
1919
@echo "make lint - Run golangci-lint"
20-
@echo "make qa - Run fmt-check, vet, and tests"
20+
@echo "make qa - Run fmt-check, vet, lint, and tests"
2121
@echo "make clean - Clean build artifacts"
2222

2323
deps:
@@ -52,7 +52,7 @@ lint:
5252
lint-install:
5353
go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@latest
5454

55-
qa: fmt-check vet test
55+
qa: fmt-check vet lint test
5656

5757
clean:
5858
rm -f $(BINARY_NAME)

0 commit comments

Comments
 (0)