fix bug where app-localstorage-document instances update instances with other keys

Author: mkazlauskas

app-localstorage/app-localstorage-document.html

@@ -204,12 +204,13 @@
       },
 
       __onAppLocalStorageChanged: function(event) {
-        if (event.detail === this) {
+        var target = event.detail;
+        if (target === this || this.key !== target.key) {
           return;
         }
 
         this.syncToMemory(function() {
-          this.set('data', event.detail.data);
+          this.set('data', target.data);
         });
       },
 

test/app-localstorage/app-localstorage-document.html

@@ -35,6 +35,8 @@
       </app-localstorage-document>
       <app-localstorage-document key="app-localstorage-test" data="{}">
       </app-localstorage-document>
+      <app-localstorage-document key="app-localstorage-other" data="{}">
+      </app-localstorage-document>
     </template>
   </test-fixture>
 
@@ -50,7 +52,7 @@
 
           return Promise.resolve(Polymer.Base.get(parts.join('.'), value));
         }
-      });      
+      });
     })
   </script>
 </body>

test/app-storage-compatibility-suite.html

@@ -221,27 +221,35 @@
       suite('syncing storage scenarios', function() {
         var storageOne;
         var storageTwo;
+        var storageOther;
 
         setup(function() {
           var syncingStorage = fixture('SyncingStorage');
 
           storageOne = syncingStorage[0];
           storageTwo = syncingStorage[1];
+          storageOther = syncingStorage[2];
 
           return Promise.all([
             storageOne.transactionsComplete,
-            storageTwo.transactionsComplete
+            storageTwo.transactionsComplete,
+            storageOther.transactionsComplete,
           ]);
         });
 
         teardown(function() {
           context.unsetValue(storageOne);
-          return context.awaitUpdate(storageTwo).then(function() {
-            expect(storageTwo.data).to.be.eql(storageOne.data);
-          });
+          context.unsetValue(storageOther);
+          return Promise.all([
+            context.awaitUpdate(storageTwo).then(function() {
+              expect(storageTwo.data).to.be.eql(storageOne.data);
+            }),
+            context.awaitUpdate(storageOther),
+          ]);
         });
 
         test('syncs primitives across elements', function() {
+          storageOther.set('data.other', 'other');
           storageOne.set('data.numberProperty', 1);
 
           return Promise.all([
@@ -252,6 +260,11 @@
             expect(value).to.be.equal(1);
             expect(storageOne.get('data.numberProperty')).to.be.equal(value);
             expect(storageTwo.get('data.numberProperty')).to.be.equal(value);
+
+            // other key
+            expect(storageOne.get('data.other')).to.not.be.ok;
+            expect(storageOther.get('data.numberProperty')).to.not.be.equal(value);
+            expect(storageOther.get('data.other')).to.be.equal('other');
           });
         });