Refactor Github Action per b/485167538

benknutson-google · benknutson-google · commit b39dff76b3c4 · 2026-02-18T11:21:38.000Z
diff --git a/.github/actions/notices_generation/action.yml b/.github/actions/notices_generation/action.yml
@@ -34,11 +34,16 @@ runs:
       cd "${{ github.action_path }}"
       bundle install
       if ${{ inputs.search-local-pod-version == 'true' }} ; then
-        ruby app.rb --pods ${{ inputs.pods }} --sources ${{ inputs.sources }} --min_ios_version ${{ inputs.min-ios-version }} --search_local_pod_version --notices_path ${{ inputs.notices-path }}
+        ruby app.rb --pods ${INPUTS_PODS} --sources ${INPUTS_SOURCES} --min_ios_version ${INPUTS_MIN_IOS_VERSION} --search_local_pod_version --notices_path ${INPUTS_NOTICES_PATH}
       else
-        ruby app.rb --pods ${{ inputs.pods }} --sources ${{ inputs.sources }} --min_ios_version ${{ inputs.min-ios-version }} --notices_path ${{ inputs.notices-path }}
+        ruby app.rb --pods ${INPUTS_PODS} --sources ${INPUTS_SOURCES} --min_ios_version ${INPUTS_MIN_IOS_VERSION} --notices_path ${INPUTS_NOTICES_PATH}
       fi
     shell: bash
+    env:
+      INPUTS_PODS: ${{ inputs.pods }}
+      INPUTS_SOURCES: ${{ inputs.sources }}
+      INPUTS_MIN_IOS_VERSION: ${{ inputs.min-ios-version }}
+      INPUTS_NOTICES_PATH: ${{ inputs.notices-path }}
   - name: Upload artifacts
     uses: actions/upload-artifact@v4
     with:
diff --git a/.github/workflows/api_diff_report.yml b/.github/workflows/api_diff_report.yml
@@ -53,17 +53,21 @@ jobs:
       - name: Generate API files for PR branch
         run: |
           python ~/api_diff_report/api_info.py \
-            --file_list ${{ steps.get_changed_files.outputs.file_list }} \
+            --file_list ${STEPS_GET_CHANGED_FILES_OUTPUTS_FILE_LIST} \
             --output_dir ${{ env.PR_API_OUTPUT }}
+        env:
+          STEPS_GET_CHANGED_FILES_OUTPUTS_FILE_LIST: ${{ steps.get_changed_files.outputs.file_list }}
 
       - name: Checkout Base branch
         run: git checkout HEAD^
 
       - name: Generate API files for Base branch
         run: |
           python ~/api_diff_report/api_info.py \
-            --file_list ${{ steps.get_changed_files.outputs.file_list }} \
+            --file_list ${STEPS_GET_CHANGED_FILES_OUTPUTS_FILE_LIST} \
             --output_dir ${{ env.BASE_API_OUTPUT }}
+        env:
+          STEPS_GET_CHANGED_FILES_OUTPUTS_FILE_LIST: ${{ steps.get_changed_files.outputs.file_list }}
 
       - name: Generate API Diff Report
         run: |
diff --git a/.github/workflows/common_quickstart.yml b/.github/workflows/common_quickstart.yml
@@ -80,13 +80,18 @@ jobs:
     - name: Xcode
       run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer
     - name: Run setup command.
-      run: ${{ inputs.setup_command }}
+      run: ${INPUTS_SETUP_COMMAND}
+      env:
+        INPUTS_SETUP_COMMAND: ${{ inputs.setup_command }}
     - name: Install Secret GoogleService-Info.plist
       run: |
           scripts/decrypt_gha_secret.sh \
-            ${{ inputs.plist_src_path }} \
-            ${{ inputs.plist_dst_path }} \
+            ${INPUTS_PLIST_SRC_PATH} \
+            ${INPUTS_PLIST_DST_PATH} \
             "$plist_secret"
+      env:
+        INPUTS_PLIST_SRC_PATH: ${{ inputs.plist_src_path }}
+        INPUTS_PLIST_DST_PATH: ${{ inputs.plist_dst_path }}
     - name: Build ${{ inputs.product }} Quickstart (${{ inputs.quickstart_type }} / ${{ inputs.is_legacy && 'Legacy' || 'Non-Legacy' }})
       uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 # v3
       with:
@@ -102,11 +107,15 @@ jobs:
     - id: lowercase_product
       if: ${{ failure() }}
       run: |
-        lowercase_product=$(echo "${{ inputs.product }}" | tr '[:upper:]' '[:lower:]')
+        lowercase_product=$(echo "${INPUTS_PRODUCT}" | tr '[:upper:]' '[:lower:]')
         echo "lowercase_product=$lowercase_product" >> $GITHUB_OUTPUT
+      env:
+        INPUTS_PRODUCT: ${{ inputs.product }}
     - name: Remove data before upload.
       if: ${{ failure() }}
-      run: scripts/remove_data.sh ${{ steps.lowercase_product.outputs.lowercase_product }}
+      run: scripts/remove_data.sh ${STEPS_LOWERCASE_PRODUCT_OUTPUTS_LOWERCASE_PRODUCT}
+      env:
+        STEPS_LOWERCASE_PRODUCT_OUTPUTS_LOWERCASE_PRODUCT: ${{ steps.lowercase_product.outputs.lowercase_product }}
     - uses: actions/upload-artifact@v4
       if: ${{ failure() }}
       with:
diff --git a/.github/workflows/health-metrics-presubmit.yml b/.github/workflows/health-metrics-presubmit.yml
@@ -53,7 +53,7 @@ jobs:
         env:
           pr_branch: ${{ github.event.pull_request.head.ref }}
         run: |
-          if [ ! -z "${{ env.METRICS_SERVICE_SECRET }}"  ]; then
+          if [ ! -z "${METRICS_SERVICE_SECRET}"  ]; then
             ./scripts/health_metrics/get_updated_files.sh
           fi
 
@@ -312,7 +312,7 @@ jobs:
 
           # Activate the service account for Metrics Service.
           scripts/decrypt_gha_secret.sh scripts/gha-encrypted/metrics_service_access.json.gpg \
-          metrics-access.json "${{ env.METRICS_SERVICE_SECRET }}"
+          metrics-access.json "${METRICS_SERVICE_SECRET}"
           gcloud auth activate-service-account --key-file metrics-access.json
       - uses: actions/download-artifact@v4.1.7
         id: download
@@ -322,9 +322,10 @@ jobs:
         if: github.event.pull_request.merged != true && github.event.action != 'closed' && github.event.pull_request.head.repo.full_name == github.repository && github.event.pull_request.base.ref == 'main'
         env:
           base_commit: ${{ needs.check.outputs.target_branch_head }}
+          STEPS_DOWNLOAD_OUTPUTS_DOWNLOAD_PATH: ${{steps.download.outputs.download-path}}
         run: |
           # Get Head commit of the branch, instead of a merge commit created by actions/checkout.
-          if [ -d "${{steps.download.outputs.download-path}}" ]; then
+          if [ -d "${STEPS_DOWNLOAD_OUTPUTS_DOWNLOAD_PATH}" ]; then
             cd scripts/health_metrics/generate_code_coverage_report
             swift run CoverageReportGenerator --presubmit "firebase/firebase-ios-sdk" --head-commit "${GITHUB_SHA}" --token $(gcloud auth print-identity-token) --xcresult-dir "/Users/runner/test/codecoverage" --log-link "https://github.com/firebase/firebase-ios-sdk/actions/runs/${GITHUB_RUN_ID}" --pull-request-num ${{github.event.pull_request.number}} --base-commit "$base_commit"
           fi
@@ -357,7 +358,9 @@ jobs:
       - name: Update New Coverage Data
         if: github.event.pull_request.merged && github.event.pull_request.head.repo.full_name == github.repository
         run: |
-          if [ -d "${{steps.download.outputs.download-path}}" ]; then
+          if [ -d "${STEPS_DOWNLOAD_OUTPUTS_DOWNLOAD_PATH}" ]; then
             cd scripts/health_metrics/generate_code_coverage_report
-            swift run CoverageReportGenerator --merge "firebase/firebase-ios-sdk" --head-commit "${GITHUB_SHA}" --token $(gcloud auth print-identity-token) --xcresult-dir "/Users/runner/test/codecoverage" --log-link "https://github.com/firebase/firebase-ios-sdk/actions/runs/${GITHUB_RUN_ID}" --source-branch "${{ github.base_ref }}"
+            swift run CoverageReportGenerator --merge "firebase/firebase-ios-sdk" --head-commit "${GITHUB_SHA}" --token $(gcloud auth print-identity-token) --xcresult-dir "/Users/runner/test/codecoverage" --log-link "https://github.com/firebase/firebase-ios-sdk/actions/runs/${GITHUB_RUN_ID}" --source-branch "${GITHUB_BASE_REF}"
           fi
+        env:
+          STEPS_DOWNLOAD_OUTPUTS_DOWNLOAD_PATH: ${{steps.download.outputs.download-path}}
diff --git a/.github/workflows/prerelease.yml b/.github/workflows/prerelease.yml
@@ -152,7 +152,7 @@ jobs:
         git config --global user.name "google-oss-bot"
     - name: Update SpecsTesting repo
       run: |
-        [[ ${{ matrix.allowwarnings }} == true ]] && ALLOWWARNINGS=true
+        [[ ${MATRIX_ALLOWWARNINGS} == true ]] && ALLOWWARNINGS=true
         cd scripts/create_spec_repo/
         swift build
         pod repo add --silent "${local_repo}" https://"$botaccess"@github.com/Firebase/SpecsTesting.git
@@ -166,6 +166,8 @@ jobs:
                                   --pod-sources 'https://${BOT_TOKEN}@github.com/Firebase/SpecsTesting' "https://github.com/firebase/SpecsDev.git" "https://github.com/firebase/SpecsStaging.git" "https://github.com/CocoaPods/Specs.git" \
                                   --include-pods "${targeted_pod}" \
                                   --keep-repo ${ALLOWWARNINGS:+--allow-warnings}
+      env:
+        MATRIX_ALLOWWARNINGS: ${{ matrix.allowwarnings }}
     - name: Clean Artifacts
       if: ${{ always() }}
       run: pod repo remove "${local_repo}"
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -137,7 +137,7 @@ jobs:
         git config --global user.name "google-oss-bot"
     - name: Update SpecsReleasing repo
       run: |
-        [[ ${{ matrix.allowwarnings }} == true ]] && ALLOWWARNINGS=true
+        [[ ${MATRIX_ALLOWWARNINGS} == true ]] && ALLOWWARNINGS=true
         cd scripts/create_spec_repo/
         swift build
         pod repo add --silent "${local_repo}" https://"$botaccess"@github.com/Firebase/SpecsReleasing.git
@@ -149,6 +149,8 @@ jobs:
                                 --pod-sources 'https://github.com/Firebase/SpecsReleasing' "https://github.com/firebase/SpecsStaging.git" "https://github.com/CocoaPods/Specs.git" \
                                 --include-pods "${targeted_pod}" \
                                 --keep-repo ${ALLOWWARNINGS:+--allow-warnings}
+      env:
+        MATRIX_ALLOWWARNINGS: ${{ matrix.allowwarnings }}
     - name: Clean Artifacts
       if: ${{ always() }}
       run: pod repo remove "${local_repo}"
diff --git a/.github/workflows/update-cpp-sdk-on-release.yml b/.github/workflows/update-cpp-sdk-on-release.yml
@@ -82,4 +82,6 @@ jobs:
       - name: Trigger firebase-cpp-sdk update
         run: |
           pip install -r scripts/gha/python_requirements.txt
-          python scripts/gha/trigger_workflow.py -t ${{ steps.generate-token.outputs.token }} -w update-dependencies.yml -p updateAndroid 0 -p updateiOS 1 -p comment "[Triggered]($GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID) by [firebase-ios-sdk $GITHUB_REF release]($GITHUB_SERVER_URL/$GITHUB_REPOSITORY/releases/tag/$GITHUB_REF)." -s 10 -A
+          python scripts/gha/trigger_workflow.py -t ${STEPS_GENERATE_TOKEN_OUTPUTS_TOKEN} -w update-dependencies.yml -p updateAndroid 0 -p updateiOS 1 -p comment "[Triggered]($GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID) by [firebase-ios-sdk $GITHUB_REF release]($GITHUB_SERVER_URL/$GITHUB_REPOSITORY/releases/tag/$GITHUB_REF)." -s 10 -A
+        env:
+          STEPS_GENERATE_TOKEN_OUTPUTS_TOKEN: ${{ steps.generate-token.outputs.token }}
