Merge branch 'main' into nc/cron-fixes

Author: ncooke3

.github/workflows/common.yml

@@ -52,6 +52,12 @@ on:
         required: false
         default: ""
 
+      # Whether the job is scheduled. Defaults to false.
+      is_nightly:
+        type: boolean
+        required: false
+        default: false
+
     outputs:
       cache_key:
         description: "The cache key for the Swift package resolution."
@@ -86,6 +92,8 @@ jobs:
     # Run on the main repo's scheduled jobs or pull requests and manual workflow invocations.
     if: (github.repository == 'firebase/firebase-ios-sdk' && github.event_name == 'schedule') || contains(fromJSON('["pull_request", "workflow_dispatch"]'), github.event_name)
     needs: [spm-package-resolved]
+    env:
+        FIREBASE_IS_NIGHTLY_TESTING: ${{ inputs.is_nightly && '1' || '' }}
     strategy:
       matrix:
         os: [macos-15]
@@ -114,6 +122,8 @@ jobs:
       run: scripts/setup_spm_tests.sh
     - uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 # v3
       if: contains(join(inputs.platforms), matrix.platform) || matrix.os == 'macos-14'
+      env:
+        FIREBASE_IS_NIGHTLY_TESTING: ${{ inputs.is_nightly && '1' || '' }}
       with:
         timeout_minutes: 15
         max_attempts: 3
@@ -123,3 +133,9 @@ jobs:
             ${{ inputs.target }} \
             ${{ matrix.platform }} \
             ${{ (contains(inputs.buildonly_platforms, matrix.platform) || contains(inputs.buildonly_platforms, 'all')) && 'spmbuildonly' || 'spm' }}
+    - uses: actions/upload-artifact@v4
+      if: ${{ failure() }}
+      with:
+        name: xcodebuild-logs-${{ inputs.target }}-${{ matrix.platform }}-${{ matrix.os }}-${{ matrix.xcode }}
+        path: xcodebuild-*.log
+        if-no-files-found: error

.github/workflows/common_quickstart_framework.yml

@@ -6,10 +6,15 @@ permissions:
 on:
   workflow_call:
     inputs:
-      # The product to test be tested (e.g. `ABTesting`).
+      # The product to be tested (e.g. `ABTesting`).
       product:
         required: true
         type: string
+      # Optional. The scheme to be tested (e.g. `ABTesting (tvOS)`).
+      scheme:
+        required: false
+        type: string
+        default: ''
       # The Run ID of a successful zip packaging workflow.
       zip_run_id:
         required: true
@@ -53,6 +58,7 @@ jobs:
     env:
       plist_secret: ${{ secrets.plist_secret }}
       SDK: ${{ inputs.product }}
+      SCHEME: ${{ inputs.scheme }}
     runs-on: ${{ inputs.os }}
     steps:
     - uses: actions/checkout@v4
@@ -82,7 +88,7 @@ jobs:
         timeout_minutes: 15
         max_attempts: 2
         retry_wait_seconds: 120
-        command: ([ -z $plist_secret ] || scripts/test_quickstart_framework.sh "${SDK}")
+        command: ([ -z $plist_secret ] || scripts/test_quickstart_framework.sh "${SDK}" "${SCHEME}")
     # Failure sequence to upload artifact.
     - uses: actions/upload-artifact@v4
       if: failure()

.github/workflows/crashlytics.yml

@@ -30,6 +30,7 @@ jobs:
     uses: ./.github/workflows/common.yml
     with:
       target: FirebaseCrashlyticsUnit
+      is_nightly: ${{ github.event_name == 'schedule' }}
 
   catalyst:
     uses: ./.github/workflows/common_catalyst.yml

.github/workflows/messaging.yml

@@ -198,6 +198,8 @@ jobs:
       run: scripts/install_prereqs.sh MessagingSampleStandaloneWatchApp watchOS
     - name: Xcode
       run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer
+    - name: Install watchOS simulators in case they are missing.
+      run: sudo xcodebuild -downloadPlatform watchOS
     - name: Build
       run: ([ -z $plist_secret ] || scripts/build.sh MessagingSampleStandaloneWatchApp watchOS)
     - name: Upload xcodebuild logs

.github/workflows/performance.yml

@@ -106,15 +106,15 @@ jobs:
         python-version: '3.11'
     - name: Xcode
       run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer
+    - name: Install xcpretty
+      run: gem install xcpretty
     - name: Setup quickstart
       run: scripts/setup_quickstart_spm.sh performance
     - name: Install Secret GoogleService-Info.plist
       run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-performance.plist.gpg \
           quickstart-ios/performance/GoogleService-Info.plist "$plist_secret"
     - name: Build swift quickstart
       run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_ftl.sh Performance swift)
-    # - name: Build objc quickstart
-    #   run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_ftl.sh Performance)
     - id: ftl_test
       uses: FirebaseExtended/github-actions/firebase-test-lab@v1.4
       with: