review

Author: paulb777

FirebaseAI/CHANGELOG.md

@@ -1,3 +1,6 @@
+# Unreleased
+- [feature] Added support for GoogleMaps grounding.
+
 # 12.9.0
 - [changed] The URL context tool APIs are now GA.
 - [feature] Added support for implicit caching (context caching) metadata in `GenerateContentResponse`.

FirebaseAI/Sources/Tool.swift

@@ -145,7 +145,7 @@ public struct Tool: Sendable {
   /// "Grounding with Google Maps" usage requirements for your chosen API provider.
   ///
   /// - Parameters:
-  ///   - googleMaps: A ``GoogleMapsConfig`` object. The presence of this object in the list
+  ///   - googleMaps: A ``GoogleMaps`` object. The presence of this object in the list
   ///     of tools enables the model to use Google Maps.
   ///
   /// - Returns: A `Tool` configured for Google Maps.
@@ -253,6 +253,8 @@ public struct LatLng: Sendable, Encodable {
   public let longitude: Double
 
   public init(latitude: Double, longitude: Double) {
+    precondition(latitude >= -90.0 && latitude <= 90.0, "Latitude must be in the range [-90.0, 90.0].")
+    precondition(longitude >= -180.0 && longitude <= 180.0, "Longitude must be in the range [-180.0, 180.0].")
     self.latitude = latitude
     self.longitude = longitude
   }

FirebaseAI/Tests/TestApp/Tests/Integration/MapsGroundingIntegrationTests.swift

@@ -34,18 +34,14 @@ struct MapsGroundingIntegrationTests {
     let candidate = try #require(response.candidates.first)
     let groundingMetadata = try #require(candidate.groundingMetadata)
 
-    #expect(!groundingMetadata.groundingChunks.isEmpty)
+    let mapChunks = groundingMetadata.groundingChunks.compactMap { $0.maps }
+    #expect(!mapChunks.isEmpty)
 
-    var foundMapChunk = false
-    for chunk in groundingMetadata.groundingChunks {
-      if let mapsChunk = chunk.maps {
-        #expect(!mapsChunk.uri.isEmpty)
-        #expect(!mapsChunk.title.isEmpty)
-        #expect(!mapsChunk.placeId.isEmpty)
-        foundMapChunk = true
-      }
+    for mapsChunk in mapChunks {
+      #expect(!mapsChunk.uri.isEmpty)
+      #expect(!mapsChunk.title.isEmpty)
+      #expect(!mapsChunk.placeId.isEmpty)
     }
-    #expect(foundMapChunk)
   }
 
   @Test(
@@ -70,17 +66,13 @@ struct MapsGroundingIntegrationTests {
     let candidate = try #require(response.candidates.first)
     let groundingMetadata = try #require(candidate.groundingMetadata)
 
-    #expect(!groundingMetadata.groundingChunks.isEmpty)
+    let mapChunks = groundingMetadata.groundingChunks.compactMap { $0.maps }
+    #expect(!mapChunks.isEmpty)
 
-    var foundMapChunk = false
-    for chunk in groundingMetadata.groundingChunks {
-      if let mapsChunk = chunk.maps {
-        #expect(!mapsChunk.uri.isEmpty)
-        #expect(!mapsChunk.title.isEmpty)
-        #expect(!mapsChunk.placeId.isEmpty)
-        foundMapChunk = true
-      }
+    for mapsChunk in mapChunks {
+      #expect(!mapsChunk.uri.isEmpty)
+      #expect(!mapsChunk.title.isEmpty)
+      #expect(!mapsChunk.placeId.isEmpty)
     }
-    #expect(foundMapChunk)
   }
 }