fix(actions): resolve reported issues in golangci-lint action

This change will fix the reported issued in the golangci-lint GitHub action related to the prealloc linter.

Signed-off-by: Rob Casale <rcasale48@verizon.net>

Author: Gearheads

pkg/app/app.go

@@ -124,7 +124,7 @@ func WithInteractive(interactive bool) Option {
 // a selection is displayed and the user must choose one
 func DefaultSelectCluster(discoverOutput *discovery.DiscoverOutput) (*discovery.Cluster, error) {
 	clusterNameToID := make(map[string]string)
-	options := []string{}
+	options := make([]string, 0, len(discoverOutput.Clusters))
 
 	for _, cluster := range discoverOutput.Clusters {
 		clusterNameToID[cluster.Name] = cluster.ID

pkg/aws/resolve.go

@@ -68,8 +68,9 @@ func ResolveRegion(cfg config.ConfigurationSet) error {
 		regionFilter = regionFilterCfg.Value.(string)
 	}
 
-	options := []string{}
-	options = append(options, ResolvePartitionRegions(partitionID)...)
+	partitionList := ResolvePartitionRegions(partitionID)
+	options := make([]string, 0, len(partitionList))
+	options = append(options, partitionList...)
 
 	options, err := utils.RegexFilter(options, regionFilter)
 	if err != nil {

pkg/azure/identity/client.go

@@ -342,7 +342,7 @@ func formatXMLText(s string) (string, error) {
 func (c *AzureADClient) encodeQueryParams(params map[string]string) string {
 	var buffer bytes.Buffer
 
-	keys := []string{}
+	keys := make([]string, 0, len(params))
 
 	for k := range params {
 		keys = append(keys, k)

pkg/config/configset.go

@@ -160,7 +160,7 @@ func (s *configSet) Get(name string) *Item {
 }
 
 func (s *configSet) GetAll() []*Item {
-	items := []*Item{}
+	items := make([]*Item, 0, len(s.config))
 	for _, item := range s.config {
 		items = append(items, item)
 	}

pkg/provider/registry/registry.go

@@ -131,7 +131,7 @@ func ListDiscoveryPluginRegistrations() []*DiscoveryPluginRegistration {
 	pluginsLock.Lock()
 	defer pluginsLock.Unlock()
 
-	plugins := []*DiscoveryPluginRegistration{}
+	plugins := make([]*DiscoveryPluginRegistration, 0, len(discoveryPlugins))
 	for _, registration := range discoveryPlugins {
 		plugins = append(plugins, registration)
 	}
@@ -143,7 +143,7 @@ func ListIdentityPluginRegistrations() []*IdentityPluginRegistration {
 	pluginsLock.Lock()
 	defer pluginsLock.Unlock()
 
-	plugins := []*IdentityPluginRegistration{}
+	plugins := make([]*IdentityPluginRegistration, 0, len(identityPlugins))
 	for _, registration := range identityPlugins {
 		plugins = append(plugins, registration)
 	}

pkg/provider/selection.go

@@ -29,7 +29,7 @@ import (
 type SelectItemFunc func(prompt string, items map[string]string) (string, error)
 
 func DefaultItemSelection(promptMessage string, items map[string]string) (string, error) {
-	options := []string{}
+	options := make([]string, 0, len(items))
 
 	for key := range items {
 		options = append(options, key)