Skip to content

Commit 3e36e85

Browse files
committed
Use Go identifiers to name my spans
This kind of distinguishes them from AWS services, too.
1 parent d9e68aa commit 3e36e85

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

internal/randomizer/app.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ func shuffle(options []string) {
5555
// All errors returned from Main are of type [Error], and support
5656
// [Error.HelpText] for user-friendly formatting.
5757
func (a App) Main(ctx context.Context, args []string) (Result, error) {
58-
ctx, span := tracer.Start(ctx, "Main")
58+
ctx, span := tracer.Start(ctx, "randomizer.Main")
5959
defer span.End()
6060

6161
request, err := a.newRequest(ctx, args)

internal/slack/token.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ func AWSParameter(name string, ttl time.Duration) TokenProvider {
7777
)
7878

7979
return func(ctx context.Context) (string, error) {
80-
ctx, span := tracer.Start(ctx, "AWSParameterTokenProvider")
80+
ctx, span := tracer.Start(ctx, "slack.AWSParameter")
8181
defer span.End()
8282

8383
select {

0 commit comments

Comments
 (0)