-
Notifications
You must be signed in to change notification settings - Fork 145
Question about code redundancy #543
Copy link
Copy link
Open
Description
Can we use that variant in
/libcraft/blocks/src/block.rs
#[allow(warnings)]
#[allow(clippy::all)]
impl BlockKind {
/// Returns the `diggable` property of this `BlockKind`.
pub fn diggable(&self) -> bool {
match self {
BlockKind::Bedrock => false,
BlockKind::Water => false,
BlockKind::Lava => false,
BlockKind::MovingPiston => false,
BlockKind::NetherPortal => false,
BlockKind::EndPortal => false,
BlockKind::EndPortalFrame => false,
BlockKind::CommandBlock => false,
BlockKind::Barrier => false,
BlockKind::EndGateway => false,
BlockKind::RepeatingCommandBlock => false,
BlockKind::ChainCommandBlock => false,
BlockKind::StructureBlock => false,
BlockKind::Jigsaw => false,
_ => true,
}
}
}
Is "true" on enum inheritor is really critical(Maybe there are other checks in other code)? Ths for reply, and sorry in advance if this is a stupid question.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels