Skip to content

Commit 76cbfab

Browse files
committed
fix: various fixes
Signed-off-by: tokoko <togurgenidze@gmail.com>
1 parent a0ba762 commit 76cbfab

File tree

6 files changed

+19
-12
lines changed

6 files changed

+19
-12
lines changed

.github/workflows/registry-rest-api-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ jobs:
145145
- name: Setup and Run Registry Rest API tests
146146
run: |
147147
echo "Running Registry REST API tests..."
148-
uv run pytest sdk/python/tests/integration/registration/rest_api/test_registry_rest_api.py --integration -s
148+
cd sdk/python && uv run pytest tests/integration/rest_api/test_registry_rest_api.py --integration -s
149149
150150
- name: Clean up docker images
151151
if: always()

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ test-python-integration-local: ## Run Python integration tests (local dev mode)
201201
FEAST_LOCAL_ONLINE_CONTAINER=True \
202202
uv run python -m pytest --tb=short -v -n auto --color=yes --integration --durations=10 --timeout=1200 --timeout_method=thread --dist loadgroup \
203203
-k "not test_lambda_materialization and not test_snowflake_materialization" \
204-
-m "not rbac_remote_integration_test" \
204+
-m "not rbac_remote_integration_test and not ray_offline_stores_only" \
205205
--ignore=sdk/python/tests/integration/compute_engines/ray_compute \
206206
--ignore=sdk/python/tests/integration/registration \
207207
--log-cli-level=INFO -s \

sdk/python/tests/benchmarks/test_key_encoding_benchmarks.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -387,9 +387,9 @@ def test_performance_regression_single_entity():
387387
serialize_entity_key(entity_key, 3)
388388
elapsed = time.perf_counter() - start_time
389389

390-
# Should be able to do 1000 single entity serializations in < 50ms
390+
# Should be able to do 1000 single entity serializations in < 100ms
391391
# Using a generous threshold to avoid flaky failures on CI runners
392-
assert elapsed < 0.05, (
392+
assert elapsed < 0.1, (
393393
f"Single entity serialization too slow: {elapsed:.4f}s for 1000 operations"
394394
)
395395

sdk/python/tests/integration/online_store/test_universal_online.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -258,6 +258,9 @@ def test_write_to_online_store(environment, universal_data_sources):
258258
"conv_rate": [0.85],
259259
"acc_rate": [0.91],
260260
"avg_daily_trips": [14],
261+
"driver_metadata": [None],
262+
"driver_config": [None],
263+
"driver_profile": [None],
261264
"event_timestamp": [pd.Timestamp(_utc_now()).round("ms")],
262265
"created": [pd.Timestamp(_utc_now()).round("ms")],
263266
}
@@ -435,6 +438,9 @@ def setup_feature_store_universal_feature_views(
435438
"conv_rate": [0.5, 0.3],
436439
"acc_rate": [0.6, 0.4],
437440
"avg_daily_trips": [4, 5],
441+
"driver_metadata": [None, None],
442+
"driver_config": [None, None],
443+
"driver_profile": [None, None],
438444
"event_timestamp": [
439445
pd.to_datetime(1646263500, utc=True, unit="s"),
440446
pd.to_datetime(1646263600, utc=True, unit="s"),

sdk/python/tests/unit/infra/test_key_encoding_utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -258,8 +258,8 @@ def test_performance_bounds_single_entity():
258258
deserialize_time = time.perf_counter() - start
259259

260260
# Performance bounds with generous thresholds to avoid flaky failures on CI runners
261-
assert serialize_time < 0.1, f"Serialization too slow: {serialize_time:.4f}s"
262-
assert deserialize_time < 0.1, f"Deserialization too slow: {deserialize_time:.4f}s"
261+
assert serialize_time < 0.2, f"Serialization too slow: {serialize_time:.4f}s"
262+
assert deserialize_time < 0.2, f"Deserialization too slow: {deserialize_time:.4f}s"
263263

264264

265265
def test_non_ascii_prefix_compatibility():

sdk/python/tests/utils/e2e_test_validation.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,10 @@
1616
from tests.integration.feature_repos.universal.data_source_creator import (
1717
DataSourceCreator,
1818
)
19-
from tests.integration.feature_repos.universal.data_sources.bigquery import (
20-
BigQueryDataSourceCreator,
21-
)
2219
from tests.integration.feature_repos.universal.data_sources.file import (
2320
FileDataSourceCreator,
2421
FileParquetDatasetSourceCreator,
2522
)
26-
from tests.integration.feature_repos.universal.data_sources.redshift import (
27-
RedshiftDataSourceCreator,
28-
)
2923

3024

3125
def validate_offline_online_store_consistency(
@@ -225,6 +219,13 @@ def make_feature_store_yaml(
225219

226220
# Only test if this is NOT a local test
227221
if os.getenv("FEAST_IS_LOCAL_TEST", "False") != "True":
222+
from tests.integration.feature_repos.universal.data_sources.bigquery import (
223+
BigQueryDataSourceCreator,
224+
)
225+
from tests.integration.feature_repos.universal.data_sources.redshift import (
226+
RedshiftDataSourceCreator,
227+
)
228+
228229
NULLABLE_ONLINE_STORE_CONFIGS.extend(
229230
[
230231
IntegrationTestRepoConfig(

0 commit comments

Comments
 (0)