fix(create-issue): address cubic-dev-ai review comments on PR #53

- gate the fields flyout badge/store on canApply so a staged-then-cleared
  value (or an unselectable radio) no longer overcounts
- carry the native dialog's assignees/labels into the create payload and
  resolve them to ids before createIssue, instead of silently dropping them
- require the discard-confirmation dialog's text to match /discard/i before
  clicking its danger button, so an unrelated confirmation is never dismissed
- value-gate the omnibar re-clear during the post-create watch window so a
  freshly-typed draft isn't wiped
- add a compile-time key-set assertion between the hand-written ProtocolMap
  and the schema-derived ProtocolMapFromSchemas so the two can't drift

Author: fathiraz

src/background/create-issue.ts

@@ -8,6 +8,7 @@ import { onMessage } from '@/lib/messages'
 import type { CreateIssueWithFieldsMessageData } from '@/lib/messages'
 import { gql } from '@/lib/graphql-client'
 import { CLONE_ISSUE, ATTACH_TO_PROJECT, UPDATE_PROJECT_FIELD } from '@/lib/graphql-mutations'
+import { GET_REPO_ASSIGNEES, GET_REPO_LABELS } from '@/lib/graphql-queries'
 import { processQueue, sleep } from '@/lib/queue'
 import type { QueueTask } from '@/lib/queue'
 import { logger } from '@/lib/debug-logger'
@@ -16,6 +17,37 @@ import { isBulkFull, acquireBulk, releaseBulk } from '@/background/concurrency'
 import { broadcastQueue, withRateLimitRetry } from '@/background/rest-helpers'
 import { getRepositoryId } from '@/background/project-helpers'
 
+// Resolves the dialog's assignee logins / label names to node ids before
+// create. Best-effort: names that don't resolve are dropped rather than
+// failing the create.
+async function resolveAssigneeIds(
+  owner: string,
+  name: string,
+  logins: string[],
+): Promise<string[]> {
+  if (logins.length === 0) return []
+  const result = await gql<{
+    repository: { assignableUsers: { nodes: { id: string; login: string }[] } }
+  }>(GET_REPO_ASSIGNEES, { owner, name, q: '' })
+  const byLogin = new Map(
+    (result.repository?.assignableUsers?.nodes || []).map((u) => [u.login, u.id]),
+  )
+  return logins.map((login) => byLogin.get(login)).filter((id): id is string => Boolean(id))
+}
+
+async function resolveLabelIds(
+  owner: string,
+  name: string,
+  labelNames: string[],
+): Promise<string[]> {
+  if (labelNames.length === 0) return []
+  const result = await gql<{
+    repository: { labels: { nodes: { id: string; name: string }[] } }
+  }>(GET_REPO_LABELS, { owner, name, q: '' })
+  const byName = new Map((result.repository?.labels?.nodes || []).map((l) => [l.name, l.id]))
+  return labelNames.map((n) => byName.get(n)).filter((id): id is string => Boolean(id))
+}
+
 function toFieldValue(value: unknown): Record<string, unknown> {
   const { singleSelectOptionId, iterationId, text, date, number: num } = value as any
   if (singleSelectOptionId) return { singleSelectOptionId }
@@ -51,6 +83,10 @@ async function runCreateIssue(data: CreateIssueWithFieldsMessageData, tabId?: nu
         detail: data.title,
         run: async () => {
           const repositoryId = await getRepositoryId(data.repoOwner, data.repoName)
+          const [assigneeIds, labelIds] = await Promise.all([
+            resolveAssigneeIds(data.repoOwner, data.repoName, data.assignees ?? []),
+            resolveLabelIds(data.repoOwner, data.repoName, data.labels ?? []),
+          ])
           logger.log('[rgp:bg] creating issue', { repositoryId, title: data.title })
           interface CreateResult {
             createIssue: { issue: { id: string; databaseId: number; number: number } }
@@ -61,6 +97,8 @@ async function runCreateIssue(data: CreateIssueWithFieldsMessageData, tabId?: nu
             repositoryId,
             title: data.title,
             body: data.body,
+            assigneeIds,
+            labelIds,
           })
           newIssueId = result.createIssue.issue.id
           await sleep(1000)

src/features/create-issue-field-flyout.tsx

@@ -12,6 +12,7 @@ import { primerCss } from '@/lib/primer-css-helper'
 import { ListCheckIcon } from '@/ui/icons'
 import { EDITABLE_PROJECT_FIELD_DATATYPES, type ProjectData } from '@/features/bulk-edit-utils'
 import { ValuePicker } from '@/features/bulk-edit-value-picker'
+import { canApply } from '@/features/bulk-edit-flyout-helpers'
 import { createIssueFieldsStore } from '@/lib/create-issue-fields-store'
 
 const chipSx = primerCss.chipButton()
@@ -116,7 +117,11 @@ export function CreateIssueFieldsChip({ getFields }: CreateIssueFieldsChipProps)
                   key={field.id}
                   field={field}
                   value={staged?.value ?? null}
-                  onChange={(next) => createIssueFieldsStore.set(field, next)}
+                  onChange={(next) =>
+                    canApply(next)
+                      ? createIssueFieldsStore.set(field, next)
+                      : createIssueFieldsStore.remove(field.id)
+                  }
                   metaQuery=""
                   setMetaQuery={noop}
                   metaResults={[]}

src/features/create-issue-injections.tsx

@@ -47,6 +47,13 @@ const TITLE_INPUT_SELECTORS = [
 
 const BODY_INPUT_SELECTORS = ['textarea[aria-label="Markdown value"]']
 
+// The dialog's metadata sidebar renders the currently-picked assignees/labels
+// as tokens once selected via their own pickers. Best-effort read: if none of
+// these match, we simply omit assignees/labels from the create payload rather
+// than failing the create.
+const ASSIGNEES_CONTAINER_SELECTORS = ['[data-testid="assignees-select-menu"]']
+const LABELS_CONTAINER_SELECTORS = ['[data-testid="labels-select-menu"]']
+
 // The board's native "+ Add item" omnibar row that (when typed into) spawns
 // this dialog with its text as the initial title. Closing the dialog through
 // our intercepted Create button skips GitHub's own handler, which normally
@@ -56,8 +63,9 @@ const OMNIBAR_INPUT_SELECTORS = ['[class*="omnibarInput"]']
 // After a "Create more" cycle, GitHub's dialog considers its form dirty and,
 // on Close, shows this native confirmation instead of closing directly. RGP's
 // own Close click doesn't know about it, so the dialog appears stuck.
-const CONFIRM_DISCARD_SELECTOR =
-  '[data-component="ConfirmationDialog"] button[data-variant="danger"]'
+const CONFIRM_DISCARD_DIALOG_SELECTOR = '[data-component="ConfirmationDialog"]'
+const CONFIRM_DISCARD_BUTTON_SELECTOR = 'button[data-variant="danger"]'
+const CONFIRM_DISCARD_TEXT_PATTERN = /discard/i
 
 // The board re-renders once the new item lands (the background's
 // create→attach→field-update chain, several seconds after dispatch), and that
@@ -119,6 +127,30 @@ function readCreateMore(dialog: Element): boolean {
   return dialog.querySelector<HTMLInputElement>(CREATE_MORE_SELECTOR)?.checked ?? false
 }
 
+function readAssignees(dialog: Element): string[] {
+  for (const sel of ASSIGNEES_CONTAINER_SELECTORS) {
+    const container = dialog.querySelector(sel)
+    if (!container) continue
+    const logins = Array.from(container.querySelectorAll<HTMLImageElement>('img[alt]'))
+      .map((img) => img.alt.replace(/^@/, '').trim())
+      .filter(Boolean)
+    if (logins.length) return logins
+  }
+  return []
+}
+
+function readLabels(dialog: Element): string[] {
+  for (const sel of LABELS_CONTAINER_SELECTORS) {
+    const container = dialog.querySelector(sel)
+    if (!container) continue
+    const names = Array.from(container.querySelectorAll('[data-testid="label-token"]'))
+      .map((el) => el.textContent?.trim() ?? '')
+      .filter(Boolean)
+    if (names.length) return names
+  }
+  return []
+}
+
 function readRepo(dialog: Element): { owner: string; name: string } | null {
   for (const sel of REPO_HEADING_SELECTORS) {
     const el = dialog.querySelector(sel)
@@ -164,6 +196,9 @@ function buildCreatePayload(
     }
   }
 
+  const assignees = readAssignees(dialog)
+  const labels = readLabels(dialog)
+
   return {
     projectId,
     repoOwner: repo.owner,
@@ -173,6 +208,8 @@ function buildCreatePayload(
     createMore: readCreateMore(dialog),
     updates,
     fieldMeta,
+    ...(assignees.length ? { assignees } : {}),
+    ...(labels.length ? { labels } : {}),
   }
 }
 
@@ -186,23 +223,46 @@ export function setupCreateIssueFieldInjector(
   let rafId: number | null = null
   let intercepting = false
   let omnibarWatchUntil: number | null = null
+  let omnibarSeedText: string | null = null
+
+  function readOmnibarValue(): string {
+    for (const sel of OMNIBAR_INPUT_SELECTORS) {
+      const el = document.querySelector<HTMLInputElement>(sel)
+      if (el) return el.value
+    }
+    return ''
+  }
 
   function clearOmnibar(): void {
     for (const sel of OMNIBAR_INPUT_SELECTORS) {
       document.querySelectorAll<HTMLInputElement>(sel).forEach(clearInput)
     }
   }
 
+  // Same as clearOmnibar, but only touches inputs whose value still matches
+  // the draft text captured at dispatch time — a value the user has since
+  // typed over is left alone instead of being wiped by the re-render watch.
+  function clearOmnibarIfUnchanged(seed: string): void {
+    for (const sel of OMNIBAR_INPUT_SELECTORS) {
+      document.querySelectorAll<HTMLInputElement>(sel).forEach((el) => {
+        if (el.value === seed) clearInput(el)
+      })
+    }
+  }
+
   // GitHub's "Discard changes?" confirmation (if our Close click triggers one)
   // mounts asynchronously — it isn't in the DOM yet on the same tick as the
   // click. Poll a few animation frames instead of checking once.
   async function dismissDiscardConfirm(timeoutMs = 5000): Promise<void> {
     const deadline = Date.now() + timeoutMs
     while (Date.now() < deadline) {
-      const btn = document.querySelector<HTMLButtonElement>(CONFIRM_DISCARD_SELECTOR)
-      if (btn) {
-        btn.click()
-        return
+      const dialog = document.querySelector<HTMLElement>(CONFIRM_DISCARD_DIALOG_SELECTOR)
+      if (dialog && CONFIRM_DISCARD_TEXT_PATTERN.test(dialog.textContent ?? '')) {
+        const btn = dialog.querySelector<HTMLButtonElement>(CONFIRM_DISCARD_BUTTON_SELECTOR)
+        if (btn) {
+          btn.click()
+          return
+        }
       }
       await new Promise((resolve) => requestAnimationFrame(resolve))
     }
@@ -241,13 +301,15 @@ export function setupCreateIssueFieldInjector(
 
       if (!payload.createMore) {
         createIssueFieldsStore.clearAll()
+        omnibarSeedText = readOmnibarValue()
         dialog.querySelector<HTMLButtonElement>('[data-component="Dialog.CloseButton"]')?.click()
         // Fallback in case some other field still marks the form dirty.
         await dismissDiscardConfirm()
         clearOmnibar()
         // The board re-renders once the new item lands (async, seconds later),
         // and that re-render restores the omnibar's original draft text once.
-        // check() re-clears it on every subsequent mutation until this expires.
+        // check() re-clears it on every subsequent mutation until this expires,
+        // but only if the user hasn't since typed a new draft into it.
         omnibarWatchUntil = Date.now() + OMNIBAR_WATCH_MS
       }
     } catch {
@@ -309,8 +371,9 @@ export function setupCreateIssueFieldInjector(
     if (omnibarWatchUntil !== null) {
       if (Date.now() > omnibarWatchUntil) {
         omnibarWatchUntil = null
-      } else {
-        clearOmnibar()
+        omnibarSeedText = null
+      } else if (omnibarSeedText !== null) {
+        clearOmnibarIfUnchanged(omnibarSeedText)
       }
     }
 

src/lib/messages.ts

@@ -1,6 +1,7 @@
 import { defineExtensionMessaging } from '@webext-core/messaging'
 import type { ExcludeCondition, SprintSettings } from '@/lib/storage'
 import type { PatErrorType } from '@/lib/errors'
+import type { ProtocolMapFromSchemas } from '@/lib/schemas-messages'
 
 export interface IssueRelationshipData {
   nodeId?: string
@@ -110,6 +111,8 @@ export interface CreateIssueWithFieldsMessageData {
   createMore: boolean
   updates: { fieldId: string; value: unknown }[]
   fieldMeta?: BulkUpdateMessageData['fieldMeta']
+  assignees?: string[]
+  labels?: string[]
 }
 
 export interface ItemPreviewData {
@@ -416,6 +419,23 @@ interface ProtocolMap {
   }): void
 }
 
+// Compile-time drift guard: `ProtocolMap` above is hand-written (kept, rather
+// than replaced by `ProtocolMapFromSchemas`, because the schema record's
+// `Schema.Array` fields are `readonly T[]` and swapping the messaging generic
+// cascades ~40 readonly/mutable mismatches into unrelated call sites). This
+// fails typecheck if the two maps' key sets diverge, so schemas-messages.ts
+// stays the source of truth for which messages exist without forcing every
+// caller onto `readonly` arrays.
+type _KeysEqual<A, B> = [keyof A] extends [keyof B]
+  ? [keyof B] extends [keyof A]
+    ? true
+    : false
+  : false
+type _AssertProtocolMapMatchesSchema =
+  _KeysEqual<ProtocolMap, ProtocolMapFromSchemas> extends true ? true : never
+
+const _protocolMapMatchesSchema: _AssertProtocolMapMatchesSchema = true
+
 const _messaging = defineExtensionMessaging<ProtocolMap>()
 export const onMessage = _messaging.onMessage
 

src/lib/schemas-messages.ts

@@ -364,6 +364,8 @@ export const Messages = {
       createMore: Schema.Boolean,
       updates: Schema.Array(BulkUpdateFieldUpdate),
       fieldMeta: Schema.optional(Schema.Record({ key: Schema.String, value: FieldMetaValue })),
+      assignees: Schema.optional(Schema.Array(Schema.String)),
+      labels: Schema.optional(Schema.Array(Schema.String)),
     }),
     output: BulkUpdateDispatchResult,
   },